test: add coverage for graph_query render_text and render_dot#1587
Merged
jamesadevine merged 1 commit intoJul 21, 2026
Merged
Conversation
Add two integration tests to cover previously untested rendering paths in src/inspect/graph_query.rs: 1. graph_text_emits_expected_sections_for_standalone_pipeline — verifies render_text emits all expected text sections (Step locations, Job edges, Job step counts, Outputs needing isOutput=true) for a standalone pipeline. 2. graph_dot_emits_subgraph_clusters_for_stage_template — verifies render_dot emits subgraph cluster blocks and fully-qualified stage.job node IDs for a stage-template fixture, covering the PipelineBodySummary::Stages branch that was previously exercised only indirectly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
marked this pull request as ready for review
July 21, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Gap Fixes
Test suite snapshot: 2,813 tests (unit + integration), 7 tests in
inspect_integration(was 5)Added Coverage
inspect/graph_query.rsrender_text— all text sectionsrender_textis a public pure function with 0 existing tests; exercises Step locations, Job edges, Job step counts, and Outputs-needing-isOutput sectionsgraph_text_emits_expected_sections_for_standalone_pipelineinspect/graph_query.rsrender_dot—PipelineBodySummary::Stagesbranchgraph_dot_emits_digraph_with_known_edgestest (which only uses astandalone/ flat-jobs fixture); theStagesarm was dead coveragegraph_dot_emits_subgraph_clusters_for_stage_templateValidation
cargo test --test inspect_integration— 7/7 passcargo clippy --all-targets --all-features— cleanThis PR was created by the automated test gap finder. Previous run: none (first run). Modules audited this cycle: sanitize, validate, fuzzy_schedule, secure, hash, ndjson, agent_stats, execute, compile/filter_ir, compile/pr_filters, compile/path_layout_check, compile/source_path_guard, compile/gitattributes, compile/codemods, inspect/graph_query, inspect/graph_deps, inspect/graph_outputs, inspect/lint, inspect/whatif.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comSee Network Configuration for more information.