refactor: reduce complexity of classify_definition in src/ado/discovery.rs

[github-actions]

What was complex

classify_definition in src/ado/discovery.rs (89 lines) constructed the same 6-field DiscoveredPipeline struct literal five times — once for every error arm of the preview_pipeline match and once for the early-return fast path. Every copy repeated definition_id: def.id, definition_name: def.name, repository_url, queue_status: def.queue_status verbatim, with only markers and status varying. This made it hard to see the actual decision logic and meant any struct-field change required five edits.

What changed

Two focused helpers were extracted:

1. make_discovered_pipeline(def, repository_url, markers, status) -> DiscoveredPipeline — consumes a DefinitionSummary and the two varying fields to build the struct in one place (9 lines).

2. classify_preview_result(def, repository_url, result) -> DiscoveredPipeline — owns the match preview_pipeline(...) arms and delegates struct construction to make_discovered_pipeline. The NotFound debug log stays in the arm that needs it (35 lines total).

classify_definition itself shrinks to ~20 lines: the fast-path early return (now a single call to make_discovered_pipeline) and a one-liner delegation to classify_preview_result.

Before / After

	Before	After
classify_definition	89 lines, struct repeated 5×	~20 lines
classify_preview_result	(inline)	35 lines
make_discovered_pipeline	(inline)	9 lines

Verification

• cargo build — clean
• cargo test — all tests pass
• cargo clippy --all-targets --all-features — no new warnings (one pre-existing match → ? warning in src/compile/common.rs, unrelated)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Cyclomatic Complexity Reducer · 137.3 AIC · ⌖ 12.2 AIC · ⊞ 7.2K · ◷