[workshop-diagrams] Add theme-aware explanatory diagram for run error checks - #2588
Merged
Merged
Conversation
Add a new light/dark SVG pair that visualises the three quick checks learners should perform when a run does not look right: 1. Does the workflow appear in Actions? 2. Does the log show useful tool calls? 3. Did something change in GitHub? Each check has a Yes path (continue to the next check / reach the 'Run looks good' terminal) and a No path pointing to a concrete fix. Files added: workshop/images/08b-error-checks-light.svg workshop/images/08b-error-checks-dark.svg Markdown change: workshop/08b-interpret-your-run.md — inserted a <picture> block with a two-sentence introduction immediately before the prose checklist in the 'Check common error patterns first' section. SVGs pass check-svg-visual-language.js and markdownlint. Playwright confirms light currentSrc ends with -light.svg and dark currentSrc ends with -dark.svg; both images are 1200×560 and nonblank. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Workshop file:
workshop/08b-interpret-your-run.mdChange type: New concept diagram (not a migration — no existing diagram covered this topic)
New SVG files:
workshop/images/08b-error-checks-light.svgworkshop/images/08b-error-checks-dark.svgWhy this diagram helps learners
The "Check common error patterns first" section previously described three diagnostic checks only as prose bullet points. Learners had to mentally map the decision logic themselves. The new diagram renders this as a top-to-bottom decision flow:
This lets learners scan the decision tree at a glance and immediately locate which fix applies to their situation, reducing back-and-forth between the prose and the actual Actions tab.
QA
check-svg-visual-language.js— 0 violations on both filesmarkdownlint-cli2— 0 issuescurrentSrcends with-light.svg, dimensions 1200×560, nonblankcurrentSrcends with-dark.svg, nonblank (62 KB screenshot)Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comawmgmcpgclients2.google.comsafebrowsingohttpgateway.googleapis.comstorage.googleapis.comwww.google.comSee Network Configuration for more information.