Reject perf-comparison iterations with invalid benchmark scripts - #254
Merged
Conversation
Agent-Logs-Url: https://github.com/githubnext/tsessebe/sessions/2ed75875-aa1e-4694-906a-6fd7dd84e8eb Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add type checking and tests to autoloop evaluation commands
Reject perf-comparison iterations with invalid benchmark scripts
Apr 30, 2026
mrjf
marked this pull request as ready for review
April 30, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoloop evaluation commands only measured their metric and never verified correctness, so iterations that broke benchmark scripts (or, in the sibling pandas-migration program, the type checker / tests) were silently accepted. This updates the
perf-comparisonevaluator to gate the metric on benchmark-script validity.Changes
.autoloop/programs/perf-comparison/program.md— evaluation block now runs validity checks before counting:bun buildeachbenchmarks/tsb/bench_*.ts(catches parse, transpile, and import-resolution errors)python3 -m py_compileeachbenchmarks/pandas/bench_*.pybun/python3is missing, emit{"benchmarked_functions": null, "rejected_reason": "..."}so the autoloop runner rejects the iteration.Running the new evaluator against the current repo immediately surfaces 5 pre-existing broken TS benchmarks (e.g.
bench_dataframe_mask.tsimports a non-existentdataFrameMaskexport) and a broken Python benchmark — exactly the regression class the gate is meant to catch. Those scripts are left as-is (out of scope) and will now correctly block iterations until fixed.Out of scope
build-tsb-pandas-typescript-migration— its program definition lives in Issue Build tsb: pandas → TypeScript migration #1, not in a repo file.AGENTS.mdforbids in-repo modification and no tool here can edit issue bodies. A maintainer should add thebunx tsc --noEmit+bun testgate to that issue body per the proposal in the originating issue.tsb-perf-evolve— already validates viabun test …/series.sortValues.test.tsinevaluate.sh; no change needed.