feat: resizable window

[adufr]

Related issues

• Instead of 400 pixels, make the height relative to the display height #433
• Make the popup window resizeable #434

Context

Make the Gitify window resizable

Discussion

I decided to make it so that it's resizable by default because IMO it's better to not have too many settings.

I used localStorage to persist the size of the window across restarts (note if you're testing it in dev, make sure you properly quit gitify using the close button instead of cmd+c the pnpm start process; otherwise the size sometimes doesn't get saved across restarts (idk why))

I had to make a small hack (menubarApp.window.webContents.executeJavaScript) to get access to the localStorage in the main.js file because it was undefined in menubarApp.window; if you have a cleaner way to do this please let me know!

[bmulholland]

Why do the function definitions need to be in the ready scope? Couldn't they be at the top level scope? Would make for cleaner code that's easier to refactor.

[afonsojramos]

As is, I disagree with the goals of this PR. I have not seen a single menubar app that allows for resizing and for a good reason I think. Either small or big, all of them allow for resizing and are always the same size. If we opt for going the depending on the screen size I suppose might consider it a bit more, but even so, I am not so sure.

[adufr]

@afonsojramos should I spend some time tinkering something that depends on the screen size or should we just close this PR and the related issues?

TBH I tried doing something because I saw 2 open issues about this and I also felt like the window was a bit too small to display multiples notifications, but I'm satisfied enough with the possibility to use cmd+ and cmd- to zoom/unzoom inside the window...

[afonsojramos]

@adufr I'm for closing because at the moment it displays already displays a good number of notifications without becoming too overwhelming. Maybe we can rethink the size, but making it adjustable or dependant on windowsize seems to be a recipe for disaster 🫠 Always happy to be proven wrong though! Besides, we're open source, so if anyone really wants to, they can whip up their own version with resizable windows.