Skip to content

refactor: clarify show notifications setting #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 2, 2024

Clarify that showNotifications is for native system notifications. Move to new System section

@setchy setchy added the refactor Refactoring of existing feature label Apr 2, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a bit confused for a bit, but then I noticed #947

@afonsojramos afonsojramos merged commit 20ad533 into main Apr 2, 2024
@afonsojramos afonsojramos deleted the feature/rename-show-notifications branch April 2, 2024 16:05
@setchy setchy added this to the Release 5.2.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants