[metadata] Move pubkey commitment out of burn transaction#44
Open
schancel wants to merge 1 commit into
Open
Conversation
Currently, for burn transactions are expected to be a hash of the combination of the pubkey and the payload hash. However, this has consequences for the topic posts which need to have a commitment to their hash directly on the blockchain, and voting transactions do not necessarily need to sign the payloads. On the other hand, for address metadata if the serialized payload does not commit to the pubkey then the burn transactions could be reusable to input many addresses into the registry server. This commit does two things: 1. Repeat the pubkey in the AddressMetadata so the hash of the serialized protobuf will commit to the pubkey. 2. Remove the need to commit to the pubkey in the OP_RETURN commitment that burns some Lotus.
Contributor
Author
|
Goes with: StampChat/stamp#655 I'm trying to decide if we want to do this, or specialize the commitment. I like people being able to fetch payloads based on the blockchain commitment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, for burn transactions are expected to be a hash of the combination of the pubkey and the payload hash. However, this has consequences for the topic posts which need to have a commitment to their hash directly on the blockchain, and voting transactions do not necessarily need to sign the payloads.
On the other hand, for address metadata if the serialized payload does not commit to the pubkey then the burn transactions could be reusable to input many addresses into the registry server.
This commit does two things: