Add epoch merkle root metadata field#247
Open
EyeOfPython wants to merge 1 commit into
Open
Conversation
EyeOfPython
force-pushed
the
epoch_merkle_root
branch
4 times, most recently
from
5a5ae3d to
22b3706
Compare
EyeOfPython
force-pushed
the
epoch_merkle_root
branch
from
cfe8530 to
2a634d7
Compare
schancel
reviewed
Mar 26, 2022
Collaborator
schancel
left a comment
schancel
left a comment
There was a problem hiding this comment.
May be worthwhile to split the epoch hash changes from this metadata change?
schancel
reviewed
Mar 26, 2022
| epochMerkleLeaves.push_back(ComputeMerkleRoot( | ||
| {pindexPrev->GetBlockHash(), pindexPrev->hashMerkleRoot}, | ||
| dummyNumLayers)); | ||
| pindexPrev = pindexPrev->pprev; |
Collaborator
There was a problem hiding this comment.
Do we need some check in here. I realize we have so many blocks as to not hit the genesis after this is activated, but seems prudent?
schancel
reviewed
Mar 26, 2022
| // Add block's own merkle root | ||
| // 0 for the block hash, as we cannot know our own block hash here | ||
| epochMerkleLeaves.push_back( | ||
| ComputeMerkleRoot({uint256(), block.hashMerkleRoot}, dummyNumLayers)); |
Collaborator
There was a problem hiding this comment.
I don't understand why we would want this.
schancel
requested changes
Nov 6, 2022
Collaborator
schancel
left a comment
schancel
left a comment
There was a problem hiding this comment.
Requesting changes to ensure no accidental merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.