feat: added resolve feature#95
Open
jeroenvervaeke wants to merge 3 commits intoglademiller:masterfrom
Open
Conversation
|
I oppose this addition because I don't think it belongs in this library. Resolving references comprehensively is non-trivial, because they may be to arbitrary paths or other documents completely. This belongs in downstream code, where the implementation only needs to satisfy the consumer's requirements specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add resolve helpers for ReferenceOr
What's this?
Makes it easier to get the value of a reference. Whether you have an inline value or a
$refpointing to#/components/, just call.resolve(&openapi)and get back a&T.Example
Works with
ReferenceOr<T>,ReferenceOr<Box<T>>, andOption<ReferenceOr<T>>.Also added some iteration helpers like
OpenAPI::operations()andPathItem::iter()while I was at it.No breaking changes, everything's backward compatible.