schema: IntegerKind: multiple_of: change type to unsigned#97
Open
spikespaz wants to merge 1 commit intoglademiller:masterfrom
Open
schema: IntegerKind: multiple_of: change type to unsigned#97spikespaz wants to merge 1 commit intoglademiller:masterfrom
spikespaz wants to merge 1 commit intoglademiller:masterfrom
Conversation
Per the JSON Schema Specification, `multipleOf` must be strictly greater than 0, and <= 0 is an invalid value. Reference: <https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-5.1> OAS 3.0.4 makes no adjustment to this keyword. Reference: <https://spec.openapis.org/oas/v3.0.4.html#x4-7-24-1-json-schema-keywords>
spikespaz
force-pushed
the
u/jacob/integer-type-multipleof-gt-0
branch
from
2116ca4 to
1070ca4
Compare
spikespaz
added a commit
to spikespaz/progeny
that referenced
this pull request
Oct 22, 2025
Hopefully this is merged in upstream `openapiv3`: <glademiller/openapiv3#97>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the JSON Schema Specification,
multipleOfmust be strictly greater than 0, and <= 0 is an invalid value.Reference:
https://datatracker.ietf.org/doc/html/draft-wright-json-schema-validation-00#section-5.1
OAS 3.0.4 makes no adjustment to this keyword.
Reference:
https://spec.openapis.org/oas/v3.0.4.html#x4-7-24-1-json-schema-keywords
Note that changing the type to
Option<u64>is insufficient to guarantee a parsing error upon an invalid specification, usingNonZeroU64will uphold this completely. If you prefer that change instead, I'm happy to adjust this PR.