Add "Cmd/Ctrl + K" shortcut to focus search input in docs #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
approved these changes
Jan 9, 2025
Will get it done. |
|
Done! For some reason the checks are not running. Please let me know if I can fix it some way. Thanks. |
|
Could you rebase on main please? I think that will fix CI |
Done sir 🕺🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4157
It adds the following shortcuts to focus the search input in generated docs
I've only tested in MacOS, and here's a screenshot. The placeholder changes to
Search Ctrl + Kon windows and linux.P.S.
I think I also have to update some docs snapshots, please lmk if it has to be done