Add code action to expand spread in patterns #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
force-pushed
the
expand-dot-dot
branch
from
8877b4e to
ab29633
Compare
lpil
reviewed
Mar 16, 2025
giacomocavalieri
force-pushed
the
expand-dot-dot
branch
from
10065ad to
388d70c
Compare
|
Should be all good, I've renamed the action to "fill in unused fields" and reverted the "unused -> ignored" change, thanks!! |
lpil
approved these changes
Mar 16, 2025
| return vec![]; | ||
| }; | ||
|
|
||
| // We add all the missing positional arguments as `_` before the first |
There was a problem hiding this comment.
I think this comment is out of date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new code action to expand a spread (
..) used in a pattern with all the ignored fields.This is what it looks like!
