-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove echo code action #4347
Remove echo code action #4347
Conversation
could there be a way to remove it from an entire module or whole src code? gleam fix? |
Could be a nice addition, I haven't thought of it that much, for now it just deletes the one under the cursor |
This needs to remove all of them to be useful I think. It's more key presses to run the code action than to delete the echo yourself if it only works for a single one. |
All echos under the selection or in the entire module? |
The entire module please. Maybe the entire package? |
Ok! When should the action trigger? Anywhere in the file? Sounds a bit annoying having that pop up every time if you have an echo in a module |
Agreed. When on an echo sounds good? |
Yeah sounds good to me, just to make sure we're on the same page: once on an echo we should offer an action "remove all |
Yes please |
af0e3c5
to
e98b792
Compare
This should be ready now! |
This is great <3
|
Something like that would be useful. We'll need to think about what would be the right API, as it'll influence future changes too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Couple tiny notes inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
This PR implements a code action to remove
echo
debug printing from the hovered expression