Fix CacheSequenceResolver for Redis with Compression & Serialization #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion on Redis Code is now compatible with Compression and Serialization for redis. The implementation is the same as Laravel used for RateLimiting using Redis. https://github.com/laravel/framework/blob/5d477f9a4080c1cdd43edd05ec4df61c738e0f8d/src/Illuminate/Cache/RateLimiter.php#L161
rzv-me
changed the title
|
@inxilpro any ETA on approving and merging this? |
|
@inxilpro FYI the method doesn't exist prior to laravel 11, I am pushing a change to fix it |
|
Hm, it shows that I closed this but I didn't mean to. Did you? |
|
no, I think some workflow triggered it and it also tagged a new version |
|
OK. Ping me when it's ready to look at again. |
|
done, had to recreate the logic as the method is not available before Laravel 11.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is now compatible with Compression and Serialization enabled for Redis.
The implementation is the same as Laravel used for RateLimiting using Redis.
src/Illuminate/Cache/RateLimiter.php
Without this change, I get this error when trying to create a snowflake ID: