Skip to content

feat: add Maxis Berhad icon#445

Open
PhatJack wants to merge 3 commits into
glincker:mainfrom
PhatJack:feat/icon-maxis-berhad
Open

feat: add Maxis Berhad icon#445
PhatJack wants to merge 3 commits into
glincker:mainfrom
PhatJack:feat/icon-maxis-berhad

Conversation

@PhatJack
Copy link
Copy Markdown
Contributor

Onboards Maxis Berhad (https://www.maxis.com.my/en/home/) to the brand catalog.

Field Value
slug maxis-berhad
title Maxis Berhad
hex 40C706
categories Telecommunications
url https://www.maxis.com.my/en/home/
collection brands
dateAdded 2026-05-28
license MIT

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label May 28, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Greptile Summary

This PR onboards the Maxis Berhad brand to the icon catalog, adding a JSON entry in src/data/icons.json alongside two new SVG assets — a standalone logo (default.svg) and a logo-plus-wordmark variant (wordmark.svg).

  • The icons.json entry is well-formed with correct metadata (slug, hex, categories, URL, dateAdded), though the opening brace on line 115127 carries a tab+space indent rather than the two-space style used by every other entry — a pre-existing concern already noted in a prior review thread.
  • Both SVG files use the identical clipPath id=\"a\", which will cause an ID collision if the two variants are ever inlined into the same HTML document; the clip path should use a unique, file-scoped identifier in each file.
  • The SVG clip paths extend far beyond the viewBox bounds (an Illustrator export artifact), which is harmless but adds unnecessary complexity; both files are also missing a trailing newline.

Confidence Score: 5/5

Safe to merge — the changes are additive only (new JSON entry + two new SVG files), with no modifications to existing logic or data.

The PR adds a self-contained brand entry. All referenced SVG files are present, metadata is correct, and nothing existing is modified. The shared clipPath id='a' between the two SVG variants is a latent concern for inline rendering, but given the clip paths span regions far larger than the viewBox, any ID resolution conflict would have no visible effect in practice.

No files require special attention — the two SVG files are straightforward new additions.

Important Files Changed

Filename Overview
public/icons/maxis-berhad/default.svg New Maxis Berhad default (logo-only) SVG icon using correct brand color #40c706; uses a clipPath with id="a" that is also used verbatim in wordmark.svg, causing an ID collision if both are ever inlined together.
public/icons/maxis-berhad/wordmark.svg New Maxis Berhad wordmark SVG (logo + "maxis" text); same clipPath id="a" clash as default.svg and also missing a trailing newline.
src/data/icons.json Adds maxis-berhad entry with correct metadata; the opening brace on line 115127 is indented with a tab+space instead of the two-space style used by every other entry (pre-existing thread already flagged this pattern).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: feat/maxis-berhad] --> B[src/data/icons.json - new maxis-berhad entry]
    A --> C[public/icons/maxis-berhad/default.svg]
    A --> D[public/icons/maxis-berhad/wordmark.svg]

    B -->|variants.default references| C
    B -->|variants.wordmark references| D

    C -->|clipPath id a| E[ID collision if both SVGs inlined in same page]
    D -->|clipPath id a| E
Loading

Reviews (2): Last reviewed commit: "feat: remove Vietnam Maritime Commercial..." | Re-trigger Greptile

Comment thread src/data/icons.json Outdated
Comment thread src/data/icons.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant