feat: add Maxis Berhad icon#445
Conversation
Greptile SummaryThis PR onboards the Maxis Berhad brand to the icon catalog, adding a JSON entry in
Confidence Score: 5/5Safe to merge — the changes are additive only (new JSON entry + two new SVG files), with no modifications to existing logic or data. The PR adds a self-contained brand entry. All referenced SVG files are present, metadata is correct, and nothing existing is modified. The shared clipPath id='a' between the two SVG variants is a latent concern for inline rendering, but given the clip paths span regions far larger than the viewBox, any ID resolution conflict would have no visible effect in practice. No files require special attention — the two SVG files are straightforward new additions.
|
| Filename | Overview |
|---|---|
| public/icons/maxis-berhad/default.svg | New Maxis Berhad default (logo-only) SVG icon using correct brand color #40c706; uses a clipPath with id="a" that is also used verbatim in wordmark.svg, causing an ID collision if both are ever inlined together. |
| public/icons/maxis-berhad/wordmark.svg | New Maxis Berhad wordmark SVG (logo + "maxis" text); same clipPath id="a" clash as default.svg and also missing a trailing newline. |
| src/data/icons.json | Adds maxis-berhad entry with correct metadata; the opening brace on line 115127 is indented with a tab+space instead of the two-space style used by every other entry (pre-existing thread already flagged this pattern). |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: feat/maxis-berhad] --> B[src/data/icons.json - new maxis-berhad entry]
A --> C[public/icons/maxis-berhad/default.svg]
A --> D[public/icons/maxis-berhad/wordmark.svg]
B -->|variants.default references| C
B -->|variants.wordmark references| D
C -->|clipPath id a| E[ID collision if both SVGs inlined in same page]
D -->|clipPath id a| E
Reviews (2): Last reviewed commit: "feat: remove Vietnam Maritime Commercial..." | Re-trigger Greptile
Onboards Maxis Berhad (https://www.maxis.com.my/en/home/) to the brand catalog.
40C706