feat: add GE Vernova icon#451
Conversation
Greptile SummaryThis PR adds GE Vernova to the brand catalog, including five SVG variants (
Confidence Score: 4/5The dark and light SVG fill colors are swapped — dark.svg is black-filled and light.svg is white-filled, which is the inverse of every other icon in the repo using these variants. The dark icon will be invisible on a dark background. The dark/light fill color inversion is a concrete rendering defect: the dark variant renders black on dark backgrounds (invisible), and the light variant renders white on light backgrounds (also invisible). The rest of the addition — default, mono, wordmark SVGs and the icons.json entry — is correct. public/icons/gevernova/dark.svg and public/icons/gevernova/light.svg need their fill colors swapped.
|
| Filename | Overview |
|---|---|
| public/icons/gevernova/dark.svg | Fill color is #000000 (black), but the repo convention for dark.svg is white fill (for visibility on dark backgrounds) — swapped with light.svg |
| public/icons/gevernova/light.svg | Fill color is #ffffff (white), but the repo convention for light.svg is black fill (for visibility on light backgrounds) — swapped with dark.svg |
| public/icons/gevernova/default.svg | Default SVG with brand color #005e60; looks correct |
| public/icons/gevernova/mono.svg | Mono SVG without explicit fill, consistent with other mono variants in the repo (e.g., gerrit/mono.svg) |
| public/icons/gevernova/wordmark.svg | Wordmark SVG with brand color #005e60; looks correct |
| src/data/icons.json | New gevernova entry added with correct slug, hex (uppercase, matching convention), categories, license, and variant paths |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[gevernova entry in icons.json] --> B[default.svg\nfill: #005e60 ✅]
A --> C[mono.svg\nno fill — inherits via CSS ✅]
A --> D[wordmark.svg\nfill: #005e60 ✅]
A --> E[dark.svg\nfill: #000000 ❌\nshould be #ffffff]
A --> F[light.svg\nfill: #ffffff ❌\nshould be #000000]
E <-->|fills are swapped| F
Reviews (2): Last reviewed commit: "fix: add viewBox attribute" | Re-trigger Greptile
| }, | ||
| { | ||
| "slug": "gevernova", | ||
| "title": "GE Vernova", | ||
| "aliases": [], | ||
| "hex": "005E60", | ||
| "categories": [ | ||
| "Energy" | ||
| ], | ||
| "variants": { | ||
| "default": "/icons/gevernova/default.svg", | ||
| "mono": "/icons/gevernova/mono.svg", | ||
| "wordmark": "/icons/gevernova/wordmark.svg", | ||
| "light": "/icons/gevernova/light.svg", | ||
| "dark": "/icons/gevernova/dark.svg" | ||
| }, | ||
| "license": "CC0-1.0", | ||
| "url": "https://www.gevernova.com/", | ||
| "dateAdded": "2026-05-29", | ||
| "collection": "brands" | ||
| }, |
There was a problem hiding this comment.
The new entry mixes tab and space indentation: the opening
{ on the line after the GetX entry is tab-indented, and the wordmark, light, and dark keys inside variants are also tab-indented. Every other entry in the file uses 2-space indentation exclusively. This will fail any JSON lint checks that enforce consistent indentation and may produce noisy diffs in future edits.
| }, | |
| { | |
| "slug": "gevernova", | |
| "title": "GE Vernova", | |
| "aliases": [], | |
| "hex": "005E60", | |
| "categories": [ | |
| "Energy" | |
| ], | |
| "variants": { | |
| "default": "/icons/gevernova/default.svg", | |
| "mono": "/icons/gevernova/mono.svg", | |
| "wordmark": "/icons/gevernova/wordmark.svg", | |
| "light": "/icons/gevernova/light.svg", | |
| "dark": "/icons/gevernova/dark.svg" | |
| }, | |
| "license": "CC0-1.0", | |
| "url": "https://www.gevernova.com/", | |
| "dateAdded": "2026-05-29", | |
| "collection": "brands" | |
| }, | |
| }, | |
| { | |
| "slug": "gevernova", | |
| "title": "GE Vernova", | |
| "aliases": [], | |
| "hex": "005E60", | |
| "categories": [ | |
| "Energy" | |
| ], | |
| "variants": { | |
| "default": "/icons/gevernova/default.svg", | |
| "mono": "/icons/gevernova/mono.svg", | |
| "wordmark": "/icons/gevernova/wordmark.svg", | |
| "light": "/icons/gevernova/light.svg", | |
| "dark": "/icons/gevernova/dark.svg" | |
| }, | |
| "license": "CC0-1.0", | |
| "url": "https://www.gevernova.com/", | |
| "dateAdded": "2026-05-29", | |
| "collection": "brands" | |
| }, |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Onboards GE Vernova (https://www.gevernova.com/) to the brand catalog.
005E60