feat: add Prosus icon#458
Conversation
Greptile SummaryThis PR adds Prosus to the brand catalog with a
Confidence Score: 4/5The icon data and SVG assets are safe to merge for functionality; the SVG files will render correctly despite the extra attributes, but they deviate from the repository's established icon format in multiple ways that should be cleaned up before merging. The JSON entry is well-formed and the SVGs will render, but both SVG files carry several unstripped design-tool artefacts (profile declaration, explicit dimensions, dead CSS, path ids) and use a non-standard large viewBox inconsistent with every other icon in the repo. There is also a tab-vs-spaces inconsistency in the JSON entry. None of these cause a runtime failure, but they leave the new assets notably out of step with the existing codebase. Both
|
| Filename | Overview |
|---|---|
| src/data/icons.json | New prosus entry is correctly structured and alphabetically ordered, but its opening brace is indented with a tab character instead of the two-space indentation used by every other entry in the file. |
| public/icons/prosus/default.svg | Contains several design-tool export artefacts (SVG Tiny PS profile declaration, explicit width/height, dead tspan style block, path id) and a non-standard large viewBox, inconsistent with every other icon in the repo which uses a clean 24×24 format. |
| public/icons/prosus/wordmark.svg | Same design-tool artefact issues as default.svg: SVG Tiny PS attributes, explicit dimensions, dead tspan CSS, path id, and a non-standard 1555×1535 viewBox. |
Reviews (1): Last reviewed commit: "feat: add Prosus icon" | Re-trigger Greptile
| "dateAdded": "2026-03-07", | ||
| "collection": "brands" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Mixed indentation: tab instead of spaces
The opening brace on this line is indented with a tab character while every other top-level entry in the file uses two spaces. This makes the prosus object the only tab-indented block in the array and will show up as a diff noise in any subsequent edit to this file. All surrounding entries (e.g. prosieben, proteus) use two-space indentation consistently.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <svg version="1.2" baseProfile="tiny-ps" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1416 1591" width="1416" height="1591"> | ||
| <title>Prosus</title> | ||
| <style> | ||
| tspan { white-space:pre } | ||
| </style> | ||
| <path id="path1551" fill="#0332af" fill-rule="evenodd" d="M1415.44 328.82L1415.44 703.86C1415.44 782.09 1386.13 850.56 1340.52 909.28C1317.7 938.63 1291.64 964.7 1259.03 987.56C1255.79 990.81 1255.79 990.81 1252.54 994.06C1158.03 925.61 1060.27 853.85 965.77 785.34C975.56 778.85 982.03 772.31 991.82 765.83C1079.84 700.57 1171.06 638.6 1259.03 573.39C1324.24 524.5 1369.81 465.78 1395.93 387.55C1402.41 371.22 1405.66 354.89 1408.95 338.61C1408.95 335.36 1408.95 332.07 1412.2 328.82C1412.2 328.82 1415.44 325.58 1415.44 328.82ZM1.24 279.89C27.3 299.46 53.36 319.03 76.18 335.36C203.25 429.94 333.59 524.5 460.71 615.77C607.35 723.39 757.22 831.03 903.86 941.88C1008.16 1016.88 1219.94 1173.41 1219.94 1173.41L1356.84 1075.6L1356.84 1492.97L1219.94 1590.85L1.24 694.07L1.24 279.89ZM894.07 5.97C946.25 12.51 995.13 25.54 1040.7 48.36C1070.05 61.44 1099.36 80.96 1122.18 100.53C1167.81 139.68 1200.42 185.32 1210.15 244.05C1223.19 306 1210.15 358.18 1174.31 410.37C1151.54 442.96 1125.43 469.03 1092.87 488.6L1089.58 491.85L1086.33 488.6C988.59 426.63 884.34 407.07 770.25 416.85C708.34 423.39 649.68 436.42 597.56 465.78C587.78 472.32 574.75 478.82 564.96 485.36C561.72 485.36 558.47 488.6 558.47 488.6L278.18 279.89C287.96 273.39 297.75 263.61 310.78 257.06C389.01 201.65 467.2 142.93 542.15 87.5C604.06 41.87 672.49 15.76 744.19 5.97C793.07 -0.53 845.19 -0.53 894.07 5.97Z" /> | ||
| </svg> No newline at end of file |
There was a problem hiding this comment.
Non-standard SVG format — design-tool artifacts included
Every other icon in this repository follows a minimal, normalised SVG structure: a single <svg> element with viewBox="0 0 24 24", no explicit width/height, no version/baseProfile, and a flat <path>. This file deviates in several ways left over from the export tool:
version="1.2" baseProfile="tiny-ps"— SVG Tiny PS profile declaration, not needed for web deliverywidth="1416" height="1591"explicit dimensions — these override theviewBoxscaling and can break responsive rendering in some consumers- The
<style>block (tspan { white-space:pre }) is an export artefact; no<tspan>elements exist in the file so the rule is dead CSS id="path1551"on the<path>— design-tool internal identifier, unnecessary in the published asset- Double space between
fill="#0332af"andfill-rule="evenodd"
The same issues appear in wordmark.svg. Stripping these artefacts and normalising to viewBox="0 0 24 24" (or at least removing the unnecessary attributes) would align both files with the repo's existing icon format.
Onboards Prosus (https://www.prosus.com) to the brand catalog.
0332AF