Skip to content

feat: add alpaca icon#469

Open
BaileySimrell wants to merge 2 commits into
glincker:mainfrom
BaileySimrell:feat/icon-alpaca
Open

feat: add alpaca icon#469
BaileySimrell wants to merge 2 commits into
glincker:mainfrom
BaileySimrell:feat/icon-alpaca

Conversation

@BaileySimrell
Copy link
Copy Markdown

Summary

  • Adds Alpaca (Alpaca Markets) brand icon from the official newsroom brand kit (alpaca-brand-external.zip).
  • Variants: default (primary logo), dark (light wordmark for dark backgrounds), mono (grayscale).
  • Brand hex: FCD72B; categories: Finance, Payment, Software.

Test plan

  • SVGs are well-formed XML with viewBox (validated locally with xmllint)
  • Each SVG is under 50KB
  • icons.json entry is alphabetically placed and schema-valid
  • CI: Validate SVG + Lint & Build pass on this PR

Made with Cursor

Add Alpaca Markets brand logos from the official newsroom asset kit
(primary, dark-background, and grayscale variants).

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label Jun 1, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Greptile Summary

This PR adds the Alpaca Markets brand icon in three variants (default, dark, mono) along with the corresponding icons.json registration.

  • SVG files: All three variants now share a consistent viewBox="0 0 1081 309", the hex color FCD72B and accent paths are correctly per-variant (white wordmark for dark, black for mono), and file sizes are well under the 50 KB limit.
  • icons.json: The entry is correctly sorted before alpine-linux, uses the project's 6-character hex convention, carries "license": "CC0-1.0" consistent with other brand entries in the file, and all required schema fields are present.

Confidence Score: 5/5

Straightforward brand icon addition with no logic changes; safe to merge

The change is purely additive — three SVG files and one JSON entry. The previously flagged viewBox mismatch is resolved (all three variants now declare viewBox="0 0 1081 309"), the duplicate path in dark.svg is no longer present, and the icons.json entry follows the existing schema conventions correctly. No application logic is affected.

No files require special attention

Important Files Changed

Filename Overview
public/icons/alpaca/default.svg New default (light background) variant of the Alpaca icon; all three SVGs now share a consistent viewBox="0 0 1081 309"
public/icons/alpaca/dark.svg New dark-background variant using white (#FFFFFF) wordmark fill; single .st2 accent path confirmed, duplicate previously flagged appears resolved
public/icons/alpaca/mono.svg New monochrome variant; all shapes rendered in #010101, consistent viewBox with the other variants
src/data/icons.json Adds alpaca entry correctly sorted before alpine-linux; schema fields (slug, hex, categories, variants, license, url, dateAdded) align with project conventions

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[icons.json entry\nslug: alpaca] --> B[default variant\ndefault.svg\n.st0 = #101010 dark text\n.st1/.st2 = #FCD72B brand yellow]
    A --> C[dark variant\ndark.svg\n.st0 = #FFFFFF white text\n.st1/.st2 = #FCD72B brand yellow]
    A --> D[mono variant\nmono.svg\n.st0/.st1 = #010101 all black]
    B & C & D --> E[viewBox: 0 0 1081 309\nconsistent across all variants]
Loading

Reviews (2): Last reviewed commit: "fix: address Greptile review on alpaca i..." | Re-trigger Greptile

Comment thread public/icons/alpaca/default.svg Outdated
Comment thread public/icons/alpaca/dark.svg
Comment thread src/data/icons.json Outdated
Align default.svg viewBox with dark/mono (1081×309), remove duplicate
path in dark.svg, and use CC0-1.0 license like other brand entries.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant