Skip to content

feat: add Vanio icon#476

Open
patoi wants to merge 2 commits into
glincker:mainfrom
patoi:main
Open

feat: add Vanio icon#476
patoi wants to merge 2 commits into
glincker:mainfrom
patoi:main

Conversation

@patoi
Copy link
Copy Markdown

@patoi patoi commented Jun 1, 2026

Description

Add new icon, Vanio Informatika

Type

  • New icon(s)
  • Icon update/fix
  • Bug fix
  • New feature
  • Documentation
  • Maintenance/chore

Checklist

  • My changes follow the project's conventions
  • I've tested the build: cd packages/icons && npm run build
  • Security audit passes: npm run audit
  • Dist validation passes: npm run validate

For icon submissions:

  • SVG has a valid viewBox attribute
  • SVG is under 50KB
  • No embedded <script> tags or event handlers
  • Icon accurately represents the official brand
  • icons.json entry is complete (slug, title, hex, categories, variants)

Related Issues

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label Jun 1, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Greptile Summary

This PR adds the Vanio Informatika brand icon, providing default.svg (colored) and mono.svg variants with a correctly set viewBox and no embedded scripts. The icons.json entry references the right vanio-informatika folder paths, addressing the path mismatch from the previous review round.

  • Both SVG files are well-formed: valid viewBox="0 0 24 24", no event handlers, under size limit.
  • The JSON "title" is "Vanio" while both SVG <title> elements read "Vanio Informatika" — the full brand name should be consistent across both.
  • The license field is absent from the new entry, unlike every adjacent entry in the file (sulu, uwsgi, etc.) which all carry "license": "MIT".

Confidence Score: 5/5

Safe to merge; changes are additive (new icon only) and the SVG files are clean and well-formed.

The SVG files are correct and harmless. The two issues in icons.json — a truncated title and a missing license field — are metadata inconsistencies that don't break any runtime path or existing icon.

src/data/icons.json — title value and missing license field.

Important Files Changed

Filename Overview
src/data/icons.json Adds the Vanio Informatika entry; variant paths now correctly reference the vanio-informatika folder, but title says "Vanio" while SVGs say "Vanio Informatika" and the license field is missing compared to surrounding entries.
public/icons/vanio-informatika/default.svg Well-formed SVG with correct viewBox, brand color fill, and a white "V" letterform; no embedded scripts or event handlers.
public/icons/vanio-informatika/mono.svg Well-formed monochrome SVG with correct viewBox; paths are combined into a single element using an even-odd fill rule.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[icons.json entry\nslug: vanio] --> B{variants}
    B --> C[default\n/icons/vanio-informatika/default.svg]
    B --> D[color\n/icons/vanio-informatika/default.svg\n⚠ same file as default]
    B --> E[mono\n/icons/vanio-informatika/mono.svg]
    C --> F[public/icons/vanio-informatika/default.svg\nfill: #65a0dc + white V]
    D --> F
    E --> G[public/icons/vanio-informatika/mono.svg\nfill: #000000 combined path]
Loading

Reviews (2): Last reviewed commit: "feat: add Vanio icon" | Re-trigger Greptile

Comment thread src/data/icons.json Outdated
Comment thread public/icons/vanio-informatika/color.svg Outdated
Comment thread public/icons/vanio-informatika/default.svg Outdated
@thegdsks
Copy link
Copy Markdown
Member

thegdsks commented Jun 7, 2026

Thanks for the contribution! A few small things before we can merge:

  1. The icons.json entry is appended at the very end of the array. Entries are kept alphabetical by slug, so the "vanio" entry should be placed alphabetically (between the existing v-prefixed entries, not at end).
  2. The variants object has both "default" and "color" pointing to the same file. Per our schema, when default is the color version you can drop the redundant "color" key (default implicitly is the color variant when present).
  3. The folder is named public/icons/vanio-informatika/ but the slug is "vanio". For consistency we prefer the folder name to match the slug. Either rename the folder to public/icons/vanio/ and update the variant paths, or change the slug to "vanio-informatika".

Since the PR is on your fork's main branch we can't push the fix on your behalf. Once you apply the three changes above we will merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants