Skip to content

feat: add Japan Post Bank icon#487

Open
PhatJack wants to merge 3 commits into
glincker:mainfrom
PhatJack:feat/icon-japanpostbank
Open

feat: add Japan Post Bank icon#487
PhatJack wants to merge 3 commits into
glincker:mainfrom
PhatJack:feat/icon-japanpostbank

Conversation

@PhatJack
Copy link
Copy Markdown
Contributor

@PhatJack PhatJack commented Jun 3, 2026

Onboards Japan Post Bank (https://www.jp-bank.japanpost.jp/en_index.html) to the brand catalog.

Field Value
slug japan-post-bank
title Japan Post Bank
hex 009900
categories Finance
url https://www.jp-bank.japanpost.jp/en_index.html
collection brands
dateAdded 2026-06-03
license CC0-1.0

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label Jun 3, 2026
@PhatJack PhatJack changed the title Feat/icon japanpostbank feat: add Japan Post Bank icon Jun 3, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 3, 2026

Greptile Summary

This PR adds Japan Post Bank to the brand catalog with two SVG assets (default.svg and wordmark.svg) and a new entry in icons.json. The brand colour (#009900) is correctly applied to all paths in both files.

  • Both SVG files carry explicit width and height attributes set to the raw artwork dimensions (1548×1087 and 1548×139), which will render at full pixel size in any <img> context without a CSS override — all other icons in the library either omit these or use small normalised values.
  • Both SVGs are missing the <title> element that every other icon in the repository includes for accessibility and tooling compatibility.
  • The icons.json entry uses a tab character to indent the opening brace instead of the two-space convention used throughout the file (previously flagged).

Confidence Score: 4/5

Safe to merge once the hardcoded large width/height attributes are resolved; the icon data and colours are otherwise correct.

The SVG files embed their intrinsic dimensions at 1548 pixels wide, which will break rendering wherever the icons are consumed as image elements without an explicit size override. Every other icon in the library avoids this by using small or omitted dimensions. This is a present rendering defect on the changed files, not a speculative concern.

Both public/icons/japan-post-bank/default.svg and public/icons/japan-post-bank/wordmark.svg need their width/height attributes corrected before the icons will render predictably across the consuming UI.

Important Files Changed

Filename Overview
public/icons/japan-post-bank/default.svg New icon SVG; both paths have correct brand colour (#009900), but the file carries hardcoded width="1548" height="1087" and is missing a <title> element — deviating from established library conventions.
public/icons/japan-post-bank/wordmark.svg New wordmark SVG; all three paths use fill="#009900" correctly, but shares the same large intrinsic dimensions (1548×139) and missing <title> issues as default.svg.
src/data/icons.json Japan Post Bank entry added with correct slug, hex, category, URL, and license; the opening brace is indented with a tab instead of two spaces (already flagged in a prior review thread).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[icons.json entry\nslug: japan-post-bank] --> B[default.svg\nviewBox 0 0 1548 1087\nwidth=1548 height=1087]
    A --> C[wordmark.svg\nviewBox 0 0 1548 139\nwidth=1548 height=139]
    B --> D{Rendered via}
    C --> D
    D -->|img tag / no CSS override| E[Renders at 1548px wide - Overflows container]
    D -->|img with explicit CSS size| F[Scales correctly via viewBox]
    D -->|inline SVG with CSS| F
Loading

Reviews (2): Last reviewed commit: "fix: add missing class attribute to Japa..." | Re-trigger Greptile

Comment thread public/icons/japan-post-bank/default.svg Outdated
Comment thread src/data/icons.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant