feat: add Japan Post Bank icon#487
Conversation
Greptile SummaryThis PR adds Japan Post Bank to the brand catalog with two SVG assets (
Confidence Score: 4/5Safe to merge once the hardcoded large width/height attributes are resolved; the icon data and colours are otherwise correct. The SVG files embed their intrinsic dimensions at 1548 pixels wide, which will break rendering wherever the icons are consumed as image elements without an explicit size override. Every other icon in the library avoids this by using small or omitted dimensions. This is a present rendering defect on the changed files, not a speculative concern. Both public/icons/japan-post-bank/default.svg and public/icons/japan-post-bank/wordmark.svg need their width/height attributes corrected before the icons will render predictably across the consuming UI.
|
| Filename | Overview |
|---|---|
| public/icons/japan-post-bank/default.svg | New icon SVG; both paths have correct brand colour (#009900), but the file carries hardcoded width="1548" height="1087" and is missing a <title> element — deviating from established library conventions. |
| public/icons/japan-post-bank/wordmark.svg | New wordmark SVG; all three paths use fill="#009900" correctly, but shares the same large intrinsic dimensions (1548×139) and missing <title> issues as default.svg. |
| src/data/icons.json | Japan Post Bank entry added with correct slug, hex, category, URL, and license; the opening brace is indented with a tab instead of two spaces (already flagged in a prior review thread). |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[icons.json entry\nslug: japan-post-bank] --> B[default.svg\nviewBox 0 0 1548 1087\nwidth=1548 height=1087]
A --> C[wordmark.svg\nviewBox 0 0 1548 139\nwidth=1548 height=139]
B --> D{Rendered via}
C --> D
D -->|img tag / no CSS override| E[Renders at 1548px wide - Overflows container]
D -->|img with explicit CSS size| F[Scales correctly via viewBox]
D -->|inline SVG with CSS| F
Reviews (2): Last reviewed commit: "fix: add missing class attribute to Japa..." | Re-trigger Greptile
Onboards Japan Post Bank (https://www.jp-bank.japanpost.jp/en_index.html) to the brand catalog.
009900