Skip to content

feat: add Mixue icon#489

Open
PhatJack wants to merge 3 commits into
glincker:mainfrom
PhatJack:feat/icon-mixue
Open

feat: add Mixue icon#489
PhatJack wants to merge 3 commits into
glincker:mainfrom
PhatJack:feat/icon-mixue

Conversation

@PhatJack
Copy link
Copy Markdown
Contributor

@PhatJack PhatJack commented Jun 4, 2026

Onboards Mixue (https://www.mxbc.com) to the brand catalog.

Field Value
slug mixue
title Mixue
hex 000000
categories Food & Beverage
url https://www.mxbc.com
collection brands
dateAdded 2026-06-04
license CC0-1.0

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label Jun 4, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 4, 2026

Greptile Summary

This PR adds Mixue (蜜雪冰城 / Mixue Bingcheng) to the brand icon catalog, contributing two SVG assets — a full-color default icon and a red-only wordmark — plus the corresponding icons.json entry.

  • src/data/icons.json: New entry has "guidelines": "" (empty string) while every other entry in the catalog uses null for absent guidelines; the entry also uses tab-based indentation instead of the 2-space standard used throughout the file.
  • public/icons/mixue/default.svg: Multi-color icon with six distinct fill colors (#e60012, #0b318f, #f39800, #fac02c, #231815, #ffffff); contains four redundant no-attribute <g> wrapper levels.
  • public/icons/mixue/wordmark.svg: Wordmark using only #e60012 (Mixue brand red) across all paths, confirming red as the primary brand color.

Confidence Score: 4/5

The JSON entry has a data-consistency issue with guidelines being an empty string instead of null, deviating from the uniform convention across the entire catalog.

The "guidelines": "" value is the only field in the entire 5,000+ entry catalog that uses an empty string where null is the established convention; any typed schema or downstream consumer that distinguishes between the two will treat this entry incorrectly.

src/data/icons.json — the guidelines field and indentation need correction before merge.

Important Files Changed

Filename Overview
src/data/icons.json Adds Mixue entry; guidelines uses empty string instead of null (breaking the catalog-wide convention), and indentation uses tabs instead of the 2-space standard used by all surrounding entries.
public/icons/mixue/default.svg New multi-color icon SVG using colors #e60012, #0b318f, #f39800, #fac02c, #231815, and #ffffff; contains 4 levels of no-attribute <g> nesting with no semantic value.
public/icons/mixue/wordmark.svg New wordmark SVG using exclusively #e60012 (Mixue brand red) for all paths — confirms the brand primary color is red, not black.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: feat/add-mixue-icon] --> B[src/data/icons.json\nNew catalog entry]
    A --> C[public/icons/mixue/default.svg\nMulti-color icon]
    A --> D[public/icons/mixue/wordmark.svg\nRed-only wordmark]

    B --> E{Field checks}
    E --> F["slug: mixue ✅"]
    E --> G["hex: 000000 ❌\n(should be e60012)"]
    E --> H["guidelines: '' ❌\n(should be null)"]
    E --> I["indentation: tabs ❌\n(should be 2-space)"]

    C --> J["Colors: #e60012, #0b318f,\n#f39800, #fac02c,\n#231815, #ffffff"]
    D --> K["Color: #e60012 only\n(confirms brand red)"]
Loading

Reviews (2): Last reviewed commit: "Update public/icons/mixue/default.svg" | Re-trigger Greptile

Comment thread src/data/icons.json
Comment on lines +77206 to 77230
{
"slug": "mixue",
"title": "Mixue",
"aliases": [
"Mixue Ice Cream & Tea",
"Mixue Bingcheng",
"蜜雪冰城"
],
"hex": "000000",
"categories": [
"Food & Beverage"
],
"variants": {
"default": "/icons/mixue/default.svg",
"wordmark": "/icons/mixue/wordmark.svg"
},
"license": "CC0-1.0",
"url": "https://www.mxbc.com",
"guidelines": "",
"dateAdded": "2026-06-04",
"collection": "brands"
},
{
"slug": "mjml",
"title": "MJML",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Incorrect brand hex color

The hex value is "000000" (pure black), but the Mixue SVG assets use a completely different palette. The wordmark SVG uses only #e60012 (red) throughout every path, making red the clear primary brand color. The PR description's table also left the hex field blank, which likely means it was filled in as a fallback. Using 000000 here will cause any downstream consumers that render icon swatches or tint icons using the hex field to display pure black instead of Mixue's actual brand red.

Comment thread src/data/icons.json
Comment on lines +77206 to 77229
{
"slug": "mixue",
"title": "Mixue",
"aliases": [
"Mixue Ice Cream & Tea",
"Mixue Bingcheng",
"蜜雪冰城"
],
"hex": "000000",
"categories": [
"Food & Beverage"
],
"variants": {
"default": "/icons/mixue/default.svg",
"wordmark": "/icons/mixue/wordmark.svg"
},
"license": "CC0-1.0",
"url": "https://www.mxbc.com",
"guidelines": "",
"dateAdded": "2026-06-04",
"collection": "brands"
},
{
"slug": "mjml",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Tabs mixed with spaces (indentation inconsistency)

The entire new object is indented with a leading tab character, while every other entry in the file uses 2-space indentation. This will show up as whitespace noise in future diffs and may break any JSON linter or formatter configured for the project. The outer { and all nested keys/values should use 2-space indentation to match the surrounding entries (e.g., {, "slug": "mixue", etc.).

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread public/icons/mixue/default.svg Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant