feat: add Maybank icon#490
Conversation
Greptile SummaryThis PR adds the Maybank brand to the icon catalog, including default, mono, and wordmark SVG variants along with the corresponding
Confidence Score: 4/5Safe to merge after fixing the mixed tab/space indentation in the JSON entry. The SVG assets and metadata are correct. The only issue is mixed tab/space characters in the src/data/icons.json — inconsistent whitespace on the opening brace and the wordmark key needs a closer look before merge.
|
| Filename | Overview |
|---|---|
| src/data/icons.json | New Maybank entry inserted in correct alphabetical position, but the opening { uses a tab character instead of 2 spaces, and the wordmark key uses three tabs instead of consistent 6-space indentation — breaking the file's uniform whitespace convention. |
| public/icons/maybank/default.svg | Default icon SVG with brand hex color #231f20; missing trailing newline at EOF. |
| public/icons/maybank/mono.svg | Mono variant correctly uses currentColor; missing trailing newline at EOF. |
| public/icons/maybank/wordmark.svg | Wordmark SVG with hardcoded brand colour across multiple paths; missing trailing newline at EOF. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[icons.json entry
slug: maybank] --> B[default.svg
fill: #231f20]
A --> C[mono.svg
fill: currentColor]
A --> D[wordmark.svg
fill: #231f20]
A --> E[Metadata
hex: 231F20
categories: Finance
license: CC0-1.0
dateAdded: 2026-06-05]
Reviews (1): Last reviewed commit: "feat: add Maybank icon" | Re-trigger Greptile
| }, | ||
| { | ||
| "slug": "maybank", | ||
| "title": "Maybank", | ||
| "aliases": [], | ||
| "hex": "231F20", | ||
| "categories": [ | ||
| "Finance" | ||
| ], | ||
| "variants": { | ||
| "default": "/icons/maybank/default.svg", | ||
| "mono": "/icons/maybank/mono.svg", | ||
| "wordmark": "/icons/maybank/wordmark.svg" | ||
| }, | ||
| "license": "CC0-1.0", | ||
| "url": "https://www.maybank2u.com.my/home/m2u/common/login.do", | ||
| "dateAdded": "2026-06-05", | ||
| "collection": "brands" | ||
| }, |
There was a problem hiding this comment.
The opening
{ on line 75079 uses a tab character for indentation, while every other entry in the file uses 2 spaces. The wordmark key on line 75090 also uses 3 tabs instead of 6 spaces. These mixed tab/space characters break the file's uniform formatting and will likely fail any JSON-lint or formatting checks in CI.
| }, | |
| { | |
| "slug": "maybank", | |
| "title": "Maybank", | |
| "aliases": [], | |
| "hex": "231F20", | |
| "categories": [ | |
| "Finance" | |
| ], | |
| "variants": { | |
| "default": "/icons/maybank/default.svg", | |
| "mono": "/icons/maybank/mono.svg", | |
| "wordmark": "/icons/maybank/wordmark.svg" | |
| }, | |
| "license": "CC0-1.0", | |
| "url": "https://www.maybank2u.com.my/home/m2u/common/login.do", | |
| "dateAdded": "2026-06-05", | |
| "collection": "brands" | |
| }, | |
| }, | |
| { | |
| "slug": "maybank", | |
| "title": "Maybank", | |
| "aliases": [], | |
| "hex": "231F20", | |
| "categories": [ | |
| "Finance" | |
| ], | |
| "variants": { | |
| "default": "/icons/maybank/default.svg", | |
| "mono": "/icons/maybank/mono.svg", | |
| "wordmark": "/icons/maybank/wordmark.svg" | |
| }, | |
| "license": "CC0-1.0", | |
| "url": "https://www.maybank2u.com.my/home/m2u/common/login.do", | |
| "dateAdded": "2026-06-05", | |
| "collection": "brands" | |
| }, |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <svg version="1.2" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1568 1568" width="1568" height="1568"> | ||
| <title>Maybank</title> | ||
| <path id="Layer" fill-rule="evenodd" fill="#231f20" d="m784.1 1567.6c-433.4 0-783.7-350.3-783.7-783.6 0-433.4 350.3-783.6 783.7-783.6 433.4 0 783.7 350.2 783.7 783.6 0 433.3-350.3 783.6-783.7 783.6zm720.8-784c0-398.8-322.2-721.1-720.7-721.1-398.6 0-720.7 322.3-720.7 721.1 0 398.7 322.1 721 720.7 721 398.5 0 720.7-322.3 720.7-721zm-1033.4-35.6c-56.1-14.4-105.4 51.3-132.8 100.8 9.5-67.8 92.9-178.9 132.8-100.8zm-123.3 0.8c18.8-64.4 63.4-88 87.2-69-32.4 10-55.8 29.2-87.2 69zm12 148.6c7.8-65.9 79.2-125.8 112.3-117.4 44.8 11.8 47.8 47.9 18.9 72.2-19.9-59-102.5 8.5-131.2 45.2zm581 126.4c5.2-84.8-77.2-124.4-93.1-211.3-15.4-87 128.7-226 37.7-368.4 171.9 138.7 37.2 220.9 124 336.1-33.7-10.2-66.9-40-77-55.7-48.3 63.6 118.4 151 8.4 299.3zm-276.6-684c20.3 0.2 55.3 14.5 41 30.8-47.6 44.4-112 26.1-163.1 71.2 20.9-55.8 114.3-63.8 122.1-102zm38.5 134c84.5-2-13.2 42.2-41.8 143.7-12.8 45-113.6 31-128.7 7.9 25.3 5 104.5-12.2 135.5-118.9 1-2.7-1.7-3.6-3.5-1.1-39.1 42.3-68.1 50-84.5 39.2-17.6 14.1-25.5 24.6-41.4 53.5-28.8-25.6-15.9-48.4 11.7-74.5 3.8-3.6-0.6-8.2-5.6-10.4-25.1-11-30.3-46.2-4.5-59.4-7.2 22.4 17.6 35.8 39.1 16.4 22.3-20.1 58.1 9 102.9-8.5 4.7-71.7 142-80.9 56.6-122.3 81.9 10 100.2 40.7 80.3 63.2-16.5 19.3-93.2 44.3-116.1 71.2zm-53.2 14.1c-21.6 1.3-33.2 0.3-40.5 0.1 11.6 30-8.9 39.8-17.1 19.1 1.7 11.4 7.3 20.1 13.6 20.1 11.4 0.2 21.4-27.6 44-39.3zm242.7-213c36.5 19.7 61 105.4 56 148.8-26.7-31.8-46-49.2-86.8-75.7-7.5-21.7 15.1-81.6 30.8-73.1zm-683.3 421.1c26.4-69.6 90.5-152.3 194.6-213.9 24-62.1 16.1-104.1 268.3-201.9 6.3-37.1 5.2-82 15.7-82 10.9 0 48.1 16.9 74.7 54.9 11-0.8 20.7-1.9 27.5-3.3 4.5-21.6 19.6-81.2 39.4-112 18-28.3 53.1-31.3 98.4 6.1 46.9 38.2 80 54 144.3 136.3 54.4 24.3 139.4 55.6 213 146-32-21.4-68.2-29.3-97.9-32.4 60 52.5 99.6 139.4 69.6 266.4-11.9-118.7-99.2-168.5-152.5-206 28.9 100-96.5 65.2-134.8-10 12.6 4 25.8 3.5 33.7-1.5-4.4-153.1-76.2-241.1-108.2-267.3-41.3-34.3-63.2 47.9-77.2 109.3-4.4 20.5-22 35.2-44.3 34.6 5-7.4 10.5-27.3 11.4-33.8-63.3 5.4-134.8 42.7-178.7 62.5-111.5 50.4-139.4 75.6-164.1 160.1-88.3 37.5-190.2 139.2-232.9 187.9zm556.2-21.4c12.4 14.2 85.9 125.2 0.8 266.4 23.2-103.9-41.5-302.8-113-201 48.5 20.9 64.4 60.5 51.3 99.1-19.8-37.3-70.2-77.4-120.2-60.9-24.9 9-58 9.2-82.7-27.9-32.1-46.6 21.9-105.2-70.1-100.5 111.3-56.3 79 53.1 132.7 66.6 62.4 14.5 69.7-23.7 91.2-48.4 17.3-21.1 49.1-36.9 82.7-14.5 15.9-48.6-7.4-125.8 38.2-166.4 16.8-15.1 70.4-13 98.1 8.7-39.4-0.4-85.8 46.6-109 178.8zm152.6 725.9c50.9-66.3 91.7-159.3 86.7-191.1-55.4 40.1-163.9 58.5-188.7 45 101.1-91.6 85.8-188.4 26.4-195.8-59.2-7.5-128.2 83.3-122.6 207.7-50-22.2-211.1 8.7-225.9-119.1-18.4-27.9-26.5-75.7-20.6-94.8 145.1 83.2 83.2-103.9 170.7-121.6-9.5-26.3-82.7-86.3-181.1 12.4-4.6 16.1-3.5 80.2 4.3 103.1-45.3-6.8-80.9-49.5-89.1-61-48.1-4.5-94.7-18-140.1-139.5-37.9-24.6-57.3-49.3-71.3-76.9 0.6-6.4 6-36.7 34.4-62.6 0 0-10.1 26.6-4.1 37.9 76.9-61.8 86.7-2.4 126.2-10.6 0.8 46.8-47.4 78.6-43.7 123.6 28.2 74.3 47.1 82.1 102.6 90.5 66.5-32.8 121.5-108.7 202.9-110.2 65.9-0.5 148.7 31.5 162.3 122.6 9.3 65.6-130.1 158.7-184.9 140.1-90 97.3 60.5 129.4 110.5 114.5 35.9-165.1 124.2-212.2 193.5-188.5 77.2 26 87.4 123.8 34.7 178.9 42.5-10.2 104.3-43.4 125.3-122.6 16.7 17.6 22 60 23.3 74.7 44.4-65 29.9-206.2-5.7-260.5 29 2.7 55.8 13.9 84.7 38.2 19.9-104.2-47.3-234.6-77.6-256.8 20.2-1.8 48.7 0 87.9 18.6-10.3-62.4-66-102.5-66-150.3 22.4 44.4 142 56.6 135.3 219.9-13.9-12.9-44-26.1-58.7-28.3 42.3 106.1 39.4 210.5 17.2 284.5-9.2-15.2-23.7-32.7-38.1-38.6 14.4 58.6-3.9 219.2-44 284 268.8-185.4 83.6-467.8 202.1-582.8-25.2 121.8 37.5 226 30.1 297.3 58.5-113.9 74.4-304.3 17.7-502 199.4 360.7 9.2 822.2-416.6 920.1zm-308.7-352.4c55.3-26.5 78.3-38.1 82.9-75 1.9-13.8-36.8-17.7-46.5-16.1 7.7 10 18 39.6 8.2 46.9-10.1 7.4-19.6-1.6-30.7-3.2-6 19.3-4.4 38.7-13.9 47.4zm-164.3-28.8c0 0-11.7-43.5-7.9-75.4-9.5 0.9-30.7 15.6-35.4 27 0.3 21.2 43.3 48.4 43.3 48.4zm-176.1-219.2c-4.2-8.1-24.3-13.9-18-32 4.1-11.9 18-11.9 20.3-17.6 2.3-4.7-8-13.4-23.6-9.3-21.6 6.3-38.6 24.4-42.6 28.9 3.4 12 35.2 45.1 55.4 59.2 16.5-10.4 10.9-23.9 8.5-29.2zm267.8 296.9c0 0-25.3-6-44-18.1-1.4 20.6 13.3 39.8 18.7 44.1 13.3-5.6 25.3-26 25.3-26z"/> | ||
| </svg> No newline at end of file |
There was a problem hiding this comment.
All three SVG files (
default.svg, mono.svg, wordmark.svg) are missing a trailing newline at end-of-file. Most editors and POSIX tools expect a terminating newline, and git will flag this with \ No newline at end of file in diffs. Adding a newline to each file keeps them consistent with the rest of the repo's text files.
Onboards Maybank (https://www.maybank2u.com.my/home/m2u/common/login.do) to the brand catalog.
231F20