Skip to content

chore: round-3 cleanup - icons.json indentation, wolt svg, icon counts#525

Merged
thegdsks merged 2 commits into
mainfrom
fix/round-3-cleanup
Jun 8, 2026
Merged

chore: round-3 cleanup - icons.json indentation, wolt svg, icon counts#525
thegdsks merged 2 commits into
mainfrom
fix/round-3-cleanup

Conversation

@thegdsks
Copy link
Copy Markdown
Member

@thegdsks thegdsks commented Jun 8, 2026

Single batched cleanup PR for accumulated Greptile P1/P2 nits plus icon-count refresh.

Changes

public/icons/wolt/default.svg - replaces an Adobe Illustrator export (xmlns:x / xmlns:i / xmlns:graph namespaces, metadata/sfw slices block, .st0 / .st1 CSS classes, id="Layer_1", xml:space="preserve", enable-background style) with a clean version using inline fills, plus role="img" and a <title> for screen readers. CSS class names are gone so inline-SVG composition cannot collide.

Icon counts - true totals are 6,104 icons and 4,487 brands. Updated marketing copy to round figures:

  • 6,030+ -> 6,100+ across README badges/copy, extensions page, compare page, categories page, 404, home hero, help fab, sitemap comment
  • packages/icons README and package.json description: 3,800+ -> 4,400+ (brands subset only)
  • README OG-image alt text aligned

src/data/posts.json is left untouched - that blog post is a dated record of the Figma plugin launch at the 6,030 mark.

Verification

Summary by CodeRabbit

  • Chores
    • Updated icon counts across product and marketing copy: main library now shows 6,100+ icons (was 6,030+) and the brand SVG package now shows 4,400+ (was 3,800+).
    • Adjusted on-site copy and summaries (hero, metadata, extension descriptions, help tips, 404, sitemap) to reflect new counts.
  • Documentation
    • README and package descriptions updated to match revised icon totals.

…counts

- src/data/icons.json: normalize 40 tab-indented lines to 2-space indentation
  across the PhatJack icon entries (MSB, Maxis Berhad, GE Vernova, Mixue,
  Maybank, etc.). Greptile flagged these per-entry during round 1; consolidating
  into a single cleanup commit instead of re-touching each merged PR.

- public/icons/wolt/default.svg: strip Adobe Illustrator namespace cruft
  (xmlns:x/i/graph, metadata/sfw block, .st0/.st1 CSS classes, id="Layer_1",
  xml:space, enable-background style); inline path fills; add role="img"
  and a <title> for screen reader support. The cleaned file matches the
  repo's standard icon format and avoids CSS-class collision when SVGs
  are inlined together.

- Icon-count refresh across README, app pages, package metadata, and
  sitemap from 6,030+ to 6,100+ (true count 6,104). packages/icons/README
  and package.json description from 3,800+ to 4,400+ (true brands subset
  4,487).

Co-Authored-By: Glinr <bot@glincker.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation ui User interface changes icons Icon data, SVGs, or variants packages npm packages (icons, cli, react, mcp) dependencies labels Jun 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 8, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR updates marketing copy to reflect revised icon counts: 6,100+ in the main application (up from 6,030+) and 4,400+ in the packages/icons package (up from 3,800+). Additionally, whitespace and indentation formatting in the icons data file is normalized.

Changes

Icon count and marketing updates

Layer / File(s) Summary
Main application marketing copy
README.md, src/app/categories/page.tsx, src/app/compare/page.tsx, src/app/extensions/page.tsx, src/app/not-found.tsx, src/app/sitemap.ts, src/components/help-fab.tsx, src/components/home-hero.tsx
Hero section, metadata descriptions, UI tooltips, page content, and sitemap comment all updated to display 6,100+ icons instead of 6,030+.
Packages/icons marketing copy
packages/icons/README.md, packages/icons/package.json
Icon count in package documentation and metadata updated from 3,800+ to 4,400+.
JSON data formatting
src/data/icons.json
Brand object entries reindented and whitespace normalized across multiple sections; all data values remain unchanged.

🎯 2 (Simple) | ⏱️ ~10 minutes


🐰 A count update hops through the code with care,
From 6,030 to 6,100 icons to share!
The data stays true, just prettier now,
With formatting clean—no logic to plow.
A marketing refresh, so spry and so bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately captures the three main components of the changeset: icons.json indentation normalization, wolt SVG cleanup, and icon count updates across documentation and UI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/round-3-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thegdsks thegdsks self-assigned this Jun 8, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 8, 2026

Greptile Summary

This chore PR batches three cleanup tasks: normalising mixed-tab indentation in src/data/icons.json, replacing the Adobe Illustrator–exported Wolt SVG with a clean inline-fill version (plus role="img" / <title>), and refreshing icon counts to 6,100+ (total) and 4,400+ (brands) across all marketing surfaces.

  • icons.json indentation — 11 entry-opener lines converted from leading tabs to 2-space indentation; the Mixue block (28 lines) is fully re-indented. Some nested variant/category keys still carry mixed whitespace ( \ ), noted in the prior review thread.
  • Wolt SVG — Adobe Illustrator namespaces, <metadata> slices block, CSS class rules, and id=\"Layer_1\" are removed; paths now use inline fill attributes, eliminating any risk of CSS-class collisions when the SVG is inlined.
  • Icon counts — 6,030+ → 6,100+ updated across 9 source files; 3,800+/4,019 → 4,400+ updated across packages/icons README, package.json, and root README.

Confidence Score: 5/5

Safe to merge — all changes are string/count updates and a straightforward SVG file replacement with no functional logic involved.

The diff is entirely marketing copy, a data-file indentation pass, and an SVG asset swap. The Wolt SVG replacement is structurally identical to the original (same paths, same fill values), just with Illustrator cruft stripped. Count strings are internally consistent across all 12 changed files. No logic, no API surface, and no data schema is affected.

No files require special attention. src/data/icons.json has residual mixed-whitespace lines in a handful of nested keys, but those were flagged in the prior review thread and do not affect JSON validity or runtime behaviour.

Important Files Changed

Filename Overview
src/data/icons.json Converts tab-indented entry openers to 2-space; nested variant/category keys in GE Vernova, Maybank, Nongfu Spring, and SanDisk still land on mixed whitespace, and the Maxis Berhad entry uses 3 spaces — residual issues flagged in prior review thread.
public/icons/wolt/default.svg Adobe Illustrator cruft removed; inline fills replace CSS classes; role="img" and title added for accessibility. Clean result with no regressions.
README.md All count references updated: total 6,030+ → 6,100+, brand icons 4,019 → 4,400+ across badges, hero copy, extensions table, and OG-image alt text.
packages/icons/README.md Brand icon count updated from 3,800+ to 4,400+ consistently across heading image alt, paragraph, and code comment.
packages/icons/package.json Description field updated from 3,800+ to 4,400+ brand icons — matches README update.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #525 - Round-3 Cleanup] --> B[icons.json indentation]
    A --> C[Wolt SVG cleanup]
    A --> D[Icon count refresh]

    B --> B1[11 entry openers: tab to 2-space]
    B --> B2[Mixue block: full 2-space re-indent]
    B --> B3[Residual mixed whitespace in nested keys]

    C --> C1[Remove AI namespaces and metadata slices]
    C --> C2[CSS classes to inline fill attributes]
    C --> C3[Add role=img + title for a11y]

    D --> D1[Root README: 6030+ to 6100+ total]
    D --> D2[Root README: 4019 to 4400+ brands]
    D --> D3[packages/icons: 3800+ to 4400+]
    D --> D4[9 app/component files: 6030+ to 6100+]
Loading

Reviews (2): Last reviewed commit: "Update README.md" | Re-trigger Greptile

Comment thread README.md Outdated
Comment thread src/data/icons.json
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@thegdsks thegdsks merged commit e519894 into main Jun 8, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies documentation Improvements or additions to documentation icons Icon data, SVGs, or variants packages npm packages (icons, cli, react, mcp) ui User interface changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant