chore: round-3 cleanup - icons.json indentation, wolt svg, icon counts#525
Conversation
…counts - src/data/icons.json: normalize 40 tab-indented lines to 2-space indentation across the PhatJack icon entries (MSB, Maxis Berhad, GE Vernova, Mixue, Maybank, etc.). Greptile flagged these per-entry during round 1; consolidating into a single cleanup commit instead of re-touching each merged PR. - public/icons/wolt/default.svg: strip Adobe Illustrator namespace cruft (xmlns:x/i/graph, metadata/sfw block, .st0/.st1 CSS classes, id="Layer_1", xml:space, enable-background style); inline path fills; add role="img" and a <title> for screen reader support. The cleaned file matches the repo's standard icon format and avoids CSS-class collision when SVGs are inlined together. - Icon-count refresh across README, app pages, package metadata, and sitemap from 6,030+ to 6,100+ (true count 6,104). packages/icons/README and package.json description from 3,800+ to 4,400+ (true brands subset 4,487). Co-Authored-By: Glinr <bot@glincker.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR updates marketing copy to reflect revised icon counts: 6,100+ in the main application (up from 6,030+) and 4,400+ in the packages/icons package (up from 3,800+). Additionally, whitespace and indentation formatting in the icons data file is normalized. ChangesIcon count and marketing updates
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis chore PR batches three cleanup tasks: normalising mixed-tab indentation in
Confidence Score: 5/5Safe to merge — all changes are string/count updates and a straightforward SVG file replacement with no functional logic involved. The diff is entirely marketing copy, a data-file indentation pass, and an SVG asset swap. The Wolt SVG replacement is structurally identical to the original (same paths, same fill values), just with Illustrator cruft stripped. Count strings are internally consistent across all 12 changed files. No logic, no API surface, and no data schema is affected. No files require special attention.
|
| Filename | Overview |
|---|---|
| src/data/icons.json | Converts tab-indented entry openers to 2-space; nested variant/category keys in GE Vernova, Maybank, Nongfu Spring, and SanDisk still land on mixed whitespace, and the Maxis Berhad entry uses 3 spaces — residual issues flagged in prior review thread. |
| public/icons/wolt/default.svg | Adobe Illustrator cruft removed; inline fills replace CSS classes; role="img" and title added for accessibility. Clean result with no regressions. |
| README.md | All count references updated: total 6,030+ → 6,100+, brand icons 4,019 → 4,400+ across badges, hero copy, extensions table, and OG-image alt text. |
| packages/icons/README.md | Brand icon count updated from 3,800+ to 4,400+ consistently across heading image alt, paragraph, and code comment. |
| packages/icons/package.json | Description field updated from 3,800+ to 4,400+ brand icons — matches README update. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR #525 - Round-3 Cleanup] --> B[icons.json indentation]
A --> C[Wolt SVG cleanup]
A --> D[Icon count refresh]
B --> B1[11 entry openers: tab to 2-space]
B --> B2[Mixue block: full 2-space re-indent]
B --> B3[Residual mixed whitespace in nested keys]
C --> C1[Remove AI namespaces and metadata slices]
C --> C2[CSS classes to inline fill attributes]
C --> C3[Add role=img + title for a11y]
D --> D1[Root README: 6030+ to 6100+ total]
D --> D2[Root README: 4019 to 4400+ brands]
D --> D3[packages/icons: 3800+ to 4400+]
D --> D4[9 app/component files: 6030+ to 6100+]
Reviews (2): Last reviewed commit: "Update README.md" | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Single batched cleanup PR for accumulated Greptile P1/P2 nits plus icon-count refresh.
Changes
public/icons/wolt/default.svg - replaces an Adobe Illustrator export (xmlns:x / xmlns:i / xmlns:graph namespaces, metadata/sfw slices block,
.st0/.st1CSS classes,id="Layer_1",xml:space="preserve",enable-backgroundstyle) with a clean version using inline fills, plusrole="img"and a<title>for screen readers. CSS class names are gone so inline-SVG composition cannot collide.Icon counts - true totals are 6,104 icons and 4,487 brands. Updated marketing copy to round figures:
src/data/posts.jsonis left untouched - that blog post is a dated record of the Figma plugin launch at the 6,030 mark.Verification
node -e 'JSON.parse(...)'passes on the updated icons.jsonxmllint --nooutclean on the new wolt SVGSummary by CodeRabbit