Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Upload and Dowload Artifact Actions to Version 3 #1196

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR changes the version of the upload and download artifact github actions from v4 to v3.

Motivation and Context

In the latest round of bumpversion PRs (#1190 and #1191), I forgot to trigger the build_wheels jobs for 2 PRs which needed them to test their behavior. It is stated on the actions/upload-artifact README that upload and download artifact v4+ are not compatible with GHES yet.

How Has This Been Tested?

If the tests pass, we are good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann tommy-waltmann requested a review from a team as a code owner January 5, 2024 18:20
@tommy-waltmann tommy-waltmann requested review from klywang and removed request for a team January 5, 2024 18:20
@tommy-waltmann tommy-waltmann merged commit 3af38f0 into master Jan 5, 2024
27 checks passed
@tommy-waltmann tommy-waltmann deleted the revert-upload-download-artifact branch January 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant