-
Couldn't load subscription status.
- Fork 152
A general model for frictional contacts in colloidal systems #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk-patch
Are you sure you want to change the base?
Conversation
|
FYI, you can execute |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Sorry, I've been very busy. I will review this pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some change requests and suggestions to improve this code.
You also need to fix the errors in the documentation build. These instructions explain how to build the documentation locally. You can merge trunk-minor into your branch to fix some of the warnings, but there are several more warnings coming from your code.
|
You will also need to merge |
…irFrictionLJBaseGPUKernel.cu that arised after removing everything related to shapes
|
Thank you for the review. I addressed all requested changes and suggestions. Two quick questions:
For example in "FrictionPairGPU.cuh" i changed : // initialize extra shared mem to char* s_extra = (char*)( ntypes); Im not sure if that is correct. My CUDA knowledge is limited, and I want to be sure it's right.
Thank you for your support. |
|
Thanks for the updates! I've pushed a few comments that apply my other suggestions directly.
This should be: so that the extra shared memory doesn't overlap with the other type parameters.
I pushed a commit that calls |
Description
I added a new class of pair force (similar to aniso). Here the relative "surface" velocity of two interacting particles is calculated (only for spherical particles) and is used to calculated a frictional force which may depend on this relative velocity. I added three frictional contact models (constant. linear, and Coulomb-Newton).
For more details see the preprint: https://arxiv.org/abs/2507.16388
Motivation and context
Frictional contacts couple translational and rotational degrees of freedom, which may affect the collective behavior of, e.g., colloids under shear and chiral active matter. Deterministic frictional contact models on the colloidal scale are thermodynamically inconsistent. This proposed model, which is roughly equivalent to DPD for anisotropic potentials, solves this inconsistency with a additional pairwise stochastic term.
How has this been tested?
The code was used to create the data presented in: https://arxiv.org/abs/2507.16388
pytest are still missing
Detailed documentation is missing
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.CHANGELOG.rstfollowing the established format.