-
Notifications
You must be signed in to change notification settings - Fork 152
Lees-Edwards boundary conditions for shear flow #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk-minor
Are you sure you want to change the base?
Conversation
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Now that 5.4 is out, this is next on my list to review. I'll look at the proposed changes soon. |
|
Thanks! I’ve also asked Kwabena to merge up trunk-minor to keep this current. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wkdarko! This looks good to me based on our internal rounds of review. I had a couple small requests below related to the fixes you pushed to the communicators, then I think it should be good to go from my side.
Description
This PR implements the Lees-Edwards boundary conditions for performing shear flow simulations.
Motivation and context
The implementation will allow users to simulate bulk rheology under full periodic boundary conditions.
How has this been tested?
Unit tests on box deformation methods were added.
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.CHANGELOG.rstfollowing the established format.