Skip to content

Conversation

@wkdarko
Copy link
Contributor

@wkdarko wkdarko commented Sep 13, 2025

Description

This PR implements the Lees-Edwards boundary conditions for performing shear flow simulations.

Motivation and context

The implementation will allow users to simulate bulk rheology under full periodic boundary conditions.

How has this been tested?

Unit tests on box deformation methods were added.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the HOOMD-blue Contributor Agreement.
  • My name is on the list of contributors (sphinx-doc/credits.rst) in the pull request source branch.
  • I have summarized these changes in CHANGELOG.rst following the established format.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale There has been no activity on this for some time. label Oct 3, 2025
@mphoward mphoward removed the stale There has been no activity on this for some time. label Oct 3, 2025
@joaander
Copy link
Member

joaander commented Oct 3, 2025

Now that 5.4 is out, this is next on my list to review. I'll look at the proposed changes soon.

@mphoward
Copy link
Collaborator

mphoward commented Oct 3, 2025

Thanks! I’ve also asked Kwabena to merge up trunk-minor to keep this current.

Copy link
Collaborator

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wkdarko! This looks good to me based on our internal rounds of review. I had a couple small requests below related to the fixes you pushed to the communicators, then I think it should be good to go from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants