-
Notifications
You must be signed in to change notification settings - Fork 0
Allow build_unit_cell
to return atom site labels
#38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cajfisher Please let me know if this fulfills your use case! Add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
additional_columns
arg tocif.build_unit_cell
to allow for replication of element symbols (and other data from the array).TODOs
NOTE
parsnip
ignores fractional occupancies while building unit cells. This is different than ASE, which always selects the most dominant species. The position data is unaffected, but users extracting additional columns should be aware that the selection of a particular species is not guaranteed.Motivation and Context
As requested in #37, it would be useful to (optionally) replicate additional data alongside the atomic positions. This functionality has been added with the
additional_columns
arg inbuild_unit_cell
, which allows returns associated data for each replicate atom. The current code returns an array for the positions and the additional data: while I considered a structured array, doing so makes indexing columns nontrivial.Multi-array return (this PR)
Structured array (alternate option)
Resolves #37
Types of Changes
Checklist: