-
Notifications
You must be signed in to change notification settings - Fork 0
Allow non-delimiting quotes in space-delimited data #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing a fixed-precision unit cell builder implementation, I ran into a pattern in AFLOW's tabular data that broke
parsnip
's parsing engine. To fix this, I added an extra conditional check to the space_delimited_data regular expression.The new pattern allows for single-quoted strings that contain single quotes that are not followed by a space (as this would indicate a delimiting whitespace). I did need to use some non-capturing groups for this pattern, but there are no lookahead/lookbehinds or labeled groups so the expression should never get catastrophic.
See point 15 from the CIF spec for examples of the pattern that was encountered here.
Previously-invalid string examples:
Outstanding issues:
Data entries that end with two single quotes in a row and are the last entry in a
loop
row will be terminated by only one of the two single quotes. I could fix this with some lookahead checks, but at the cost of a significant performance hit.Types of Changes
1The change breaks (or has the potential to break) existing functionality and should be merged into the
breaking
branchChecklist: