Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few fixes for improving css reliability #18375

Merged
merged 2 commits into from
Nov 25, 2024
Merged

a few fixes for improving css reliability #18375

merged 2 commits into from
Nov 25, 2024

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Nov 22, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • add fallback for font-family
  • remove strange/unknown properties
  • remove duplicated properties
  • improper usage
  • For a few, completely remove the classes as they don't seem to be used. It was reported as sonarcloud on various issues like the above points.

@orthagh orthagh changed the title a few fix for improving css reliability a few fixes for improving css reliability Nov 22, 2024
@cedric-anne cedric-anne merged commit be7d854 into glpi-project:main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cconard96 cconard96 Awaiting requested review from cconard96

@cedric-anne cedric-anne Awaiting requested review from cedric-anne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orthagh @trasher @AdrienClairembault @cedric-anne