fix(save-search): correct total calculation for itemtype #18376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
requested changes
Nov 25, 2024
There was a problem hiding this comment.
I am not sure this fix is correct. The prepareQueryToUse() method is able to handle search criteria that no longer match a valid search option, for instance a search option related to an itemtype of a plugin that is no longer active. See usage of the $enable_partial_warnings method parameter.
Rom1-B
suggested changes
Nov 25, 2024
| $query_tab, | ||
| $enable_partial_warnings | ||
| ); | ||
| $query_tab = null; |
4 tasks
|
Replaced by #18385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (if appropriate):