-
-
Couldn't load subscription status.
- Fork 1.5k
[HLAPI] Add some missing timeline properties #21369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLAPI] Add some missing timeline properties #21369
Conversation
|
May I ask why this is planned for 11.1? The new API has its own versioning and is capable of supporting multiple versions at the same time for schemas and endpoints. The new properties in this PR will be exclusive to version 2.1 and if users request v2.0 (/api.php/v2.0/), these new properties will not be used. In fact, I planned to open a PR soon to add an API version pinning feature for Webhooks to allow users to pin their webhooks to specific API versions to try to keep them stable as the API evolves. |
To be honnest, I cannot tell which milestone should be targetted. If we continue to add small enhancements in the 11.0 version, then we will probably require a few months to stabilize it, like we did for the 10.0 version, and we will not be able to focus on the 11.1 release. |
|
IMO, new schemas and endpoints are some of the safest changes that can be made in a bugfix GLPI version. Given that there are a lot of things missing in the new API at the same time we are pushing people away from the legacy API, I believed improving on coverage during 11.0.X would be better than waiting 6 months or more for 11.1. There are other types of API changes which I would want to wait of course, like the introduction of cursor-based pagination which offers much better performance than offset-based pagination (if I can comfortably get it working reliably with complex filters). |
|
The one thing I want to avoid though is having a new minor version of the API with only one or two additions. |
a3d899d to
0ae8207
Compare
|
List of id for HLAPI missing endpoints or data: #21335, #21369, #21537, #21539, #21541 To moderate a bit my thoughts, these PR shouldn't include BC breaks or only if delivered API endpoint is bugged |
9cd027b to
ca4c40b
Compare
6a298dd to
3abae4d
Compare
3abae4d to
88a219f
Compare
69d7151
into
glpi-project:feature/hlapi-v2.1
Checklist before requesting a review
Description
Requires #21611
Add several properties than were missing related to ITIL items and the timeline items:
uuid,user_tech,group_tech,date,date_creation,date_mod,planned_begin,planned_end,timeline_position,source_item_id, andsource_of_item_idproperties for the applicable Ticket, Change and Problem Task schemas in the High-Level API v2.1.date,timeline_position,source_item_id, andsource_of_item_idproperties for the Followup schema in the High-Level API v2.1.approver,approval_followup,date_creation,date_mod, anddate_approvalproperties for the Solution schema in the High-Level API v2.1.timeline_positionproperty for the TicketValidation, ChangeValidation and Document_Item schemas in the High-Level API v2.1.date_solve,date_close, andglobal_validationproperties for the applicable Ticket, Change and Problem schemas in the High-Level API v2.1.