[HLAPI] Some schema validity fixes and changes #21637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Added some missing properties for v2.1.Nothing here should be a BC break.
See CHANGELOG for more information.
With the new GraphQL test, I identified a property name mismatch between the partial and full schemas for Users. In the full schema, the name field is exposed as "username" while the partial still shows it as "name". This is annoying but doesn't block the use. The GraphQL schemas all show the correct property name "username" for dropdowns since it expands the partial schemas automatically. A note and assertion was added in the test to enforce that it is fixed for v3 of the API.
Also found there are duplicate
SoftwareLicenseandLicenseschemas. They will be fixed in v3 but for now at least there is a check to ensure they have the same properties. Again, not a blocker but just an annoyance or point of user confusion.