Skip to content

[client] opengl: initialize scale to 1.0 #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobmcnamee
Copy link
Contributor

Fixes SPICE cursor rendering unconditionally at (0, 0) prior to KVMFR frame format configuration (using OpenGL renderer).

Presently cursor coordinates are multiplied by scale = 0 in opengl_onMouseEvent until opengl_onFrameFormat.

I observe this problem with a Win 10 VM using QXL video by running looking-glass-client app:renderer=OpenGL .

Note that some video devices / configurations embed the cursor in the video stream rather than sending SPICE cursor messages:

  • QXL apparently defaults to a hardware cursor which is forwarded via SPICE (thus the issue manifests)
  • Virtio currently disables hardware cursor support unless overridden via the registry (thus no issue for now)
  • VGA seems unaffected

Fixes SPICE cursor rendering unconditionally at (0, 0) prior to KVMFR
frame format configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant