Skip to content

feat: API: Add CreateLedger #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Jul 8, 2025

The Keybase API already has CreateLedger. Since I got a hardware Ledger for testing, we can support CreateLedger in Gno Native Kit.

  • In gnonativetypes.go, add CreateLedgerRequest and CreateLedgerResponse
  • In rpc.proto, add CreateLedger
  • Run make regenerate
  • In gnoNativeService, add CreateLedger

Signed-off-by: Jeff Thompson <[email protected]>
@jefft0 jefft0 requested a review from D4ryl00 July 9, 2025 08:20
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit 940ae12 into gnolang:main Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants