Skip to content

Conversation

@Hedrik
Copy link

@Hedrik Hedrik commented Oct 31, 2014

some debug output added to Operator.pm and prd.pl, de-duplication of code in Parser.pm, actually print in Print.pm

Added additional test scripts
Changed to process all tests despite any with parse errors
Added more tests
Also trim single-item arrays through infinite depth
Optimizes correctly for more than 2 operands with the same operator
@Hedrik Hedrik changed the title Couple simple changes to start Couple simple changes to start, including working operator with > 2 operands Oct 31, 2014
@plambert
Copy link
Contributor

Hey, I made some github comments on the changes.

I'm really sorry for not deleting the prl.pl file; it really should just be:

#!/bin/sh
prove

And that's it... :)

In fact, if you have installed the Prerequisites listed, you should be able
to run 'autoprove' in the directory in one terminal, and it'll re-run the
tests in t/*.t each time you update a file.

Paul

On Thu, Oct 30, 2014 at 10:49 PM, Richard A. Mead [email protected]
wrote:

some debug output added to Operator.pm and prd.pl, de-duplication of code

in Parser.pm, actually print in Print.pm

You can merge this Pull Request by running

git pull https://github.com/Hedrik/d20dsl master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Updated to actually display output from print statements
  • more tests
  • remove dup code in grammar
  • add debug output

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#1.

@Hedrik
Copy link
Author

Hedrik commented Nov 1, 2014

Um, OK... Where do I find these comments you made?

I try the autoprove for testing.

Not sure what you meant by munged output from multiple expressions in a
print statement... Maybe that is one of the tests? I'll check the t/
directory.

On Fri, Oct 31, 2014 at 3:11 PM, Paul M. Lambert [email protected]
wrote:

Hey, I made some github comments on the changes.

I'm really sorry for not deleting the prl.pl file; it really should just
be:

#!/bin/sh
prove

And that's it... :)

In fact, if you have installed the Prerequisites listed, you should be able
to run 'autoprove' in the directory in one terminal, and it'll re-run the
tests in t/*.t each time you update a file.

Paul

On Thu, Oct 30, 2014 at 10:49 PM, Richard A. Mead <
[email protected]>
wrote:

some debug output added to Operator.pm and prd.pl, de-duplication of
code

in Parser.pm, actually print in Print.pm

You can merge this Pull Request by running

git pull https://github.com/Hedrik/d20dsl master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Updated to actually display output from print statements
  • more tests
  • remove dup code in grammar
  • add debug output

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#1.


Reply to this email directly or view it on GitHub
#1 (comment).

@Hedrik
Copy link
Author

Hedrik commented Apr 8, 2023

Yo, these changes still look like they apply... though there is some merge work to be done perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants