Skip to content

Conversation

@gcasa
Copy link
Member

@gcasa gcasa commented Dec 6, 2025

This PR is to implement the encoding for all of the NS*Formatter classes that were previously added. The test for this is here... https://github.com/gcasa/EncodingTest. You will need to decode the compressed plist using this...

for i in `ls *.archive`\ndo\nplutil -convert xml1 $i\necho $i\ndone

I have implemented the keys as this indicates. I am currently testing this with the changes being made in Gorm to add inspectors for these changes... that branch is this... 91-add-a-palette-to-support-other-formatters.

@gcasa gcasa requested a review from rfm as a code owner December 6, 2025 02:10
@gcasa gcasa changed the title Update encoding for NSByteCountFormatter Update encoding for new NSFormatter subclasses Dec 7, 2025
@gcasa
Copy link
Member Author

gcasa commented Dec 7, 2025

Changes for this are complete. Please review and let me know.

Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While all the changes look good, I think they would be better with testcases in Tests/base/... so that we know they actually perform OSX compatible coding.
The EncodingTest project looks like a start, but needs to have all the external dependencies removed and to be reworked to be part of the testsuite (ideally as a set of testcases which will run on both Apple and GNUstep).
I know we have a lot of testcases which work on one platform but not the other: let's strive to improve that.

@gcasa
Copy link
Member Author

gcasa commented Dec 8, 2025

While all the changes look good, I think they would be better with testcases in Tests/base/... so that we know they actually perform OSX compatible coding. The EncodingTest project looks like a start, but needs to have all the external dependencies removed and to be reworked to be part of the testsuite (ideally as a set of testcases which will run on both Apple and GNUstep). I know we have a lot of testcases which work on one platform but not the other: let's strive to improve that.

Sounds good. I will do that today.

@gcasa
Copy link
Member Author

gcasa commented Dec 9, 2025

I have all tests passing now. Also I used the *.archive files created by the unit test I had attached to add tests for all formatters and to make sure that the keys that are being create are the ones being used by GNUstep so that keys are macOS compatible.

@gcasa
Copy link
Member Author

gcasa commented Dec 9, 2025

I believe this is now ready for review. Please let me know what you think @rfm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants