-
Notifications
You must be signed in to change notification settings - Fork 290
Update encoding for new NSFormatter subclasses #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…and fix key names in NSMassFormatter NSCoder methods.
|
Changes for this are complete. Please review and let me know. |
rfm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While all the changes look good, I think they would be better with testcases in Tests/base/... so that we know they actually perform OSX compatible coding.
The EncodingTest project looks like a start, but needs to have all the external dependencies removed and to be reworked to be part of the testsuite (ideally as a set of testcases which will run on both Apple and GNUstep).
I know we have a lot of testcases which work on one platform but not the other: let's strive to improve that.
Sounds good. I will do that today. |
…tly and fix unitStringFrom... methods.
|
I have all tests passing now. Also I used the *.archive files created by the unit test I had attached to add tests for all formatters and to make sure that the keys that are being create are the ones being used by GNUstep so that keys are macOS compatible. |
|
I believe this is now ready for review. Please let me know what you think @rfm |
This PR is to implement the encoding for all of the NS*Formatter classes that were previously added. The test for this is here... https://github.com/gcasa/EncodingTest. You will need to decode the compressed plist using this...
I have implemented the keys as this indicates. I am currently testing this with the changes being made in Gorm to add inspectors for these changes... that branch is this... 91-add-a-palette-to-support-other-formatters.