Show Org-level Project in Repo-projects list #33830
Open
+54
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
reviewed
Mar 10, 2025
| return | ||
| } | ||
|
|
||
| closeOrgProjects, closeCountForOrgProjects, err := db.FindAndCount[project_model.Project](ctx, project_model.SearchOptions{ |
There was a problem hiding this comment.
Is it necessary to load both open and closed org projects?
There was a problem hiding this comment.
it maybe necessary, you need to get the number of open projects and closed projects, in previous logic you can just get repo level projects other than org level projects.
There was a problem hiding this comment.
You can use db.Count for those non-current selected org level projects rather than db.FindAndCount.
There was a problem hiding this comment.
i mean even if you use db.count, still need to get the number of open projects and closed projects
There was a problem hiding this comment.
yes, I mean. For open state, you can use db.FindAndCount get opened projects and use db.Count for closed number. For close state, you can use db.FindAndCount get closed projects and use db.Count for opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33378