Remove HasWiki method and use IsWikiRepositoryExist #33912
+119
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
a1012112796
reviewed
Mar 17, 2025
routers/web/repo/wiki.go
Outdated
Comment on lines
606
to
611
| hasWiki, err := gitrepo.IsWikiRepositoryExist(ctx, ctx.Repo.Repository) | ||
| if err != nil { | ||
| ctx.ServerError("IsWikiRepositoryExist", err) | ||
| return | ||
| } | ||
| if !hasWiki { |
There was a problem hiding this comment.
looks in previous design, error from util.IsDir was ignored with a log be added, are you sure it's necessary to change this logic to return an 500 error?
There was a problem hiding this comment.
util.IsDir has checked os.IsNotExist(err), so I don't think the error should be ignored.
wxiaoguang
requested changes
Mar 17, 2025
GiteaBot
added
lgtm/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.