Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli flags LDAP group configuration #33933

Merged
merged 9 commits into from
Mar 20, 2025
Merged

Add cli flags LDAP group configuration #33933

merged 9 commits into from
Mar 20, 2025
+77 −0

Conversation

TheFox0x7
Copy link
Contributor

@TheFox0x7 TheFox0x7 commented Mar 18, 2025 •
edited
Loading

Add 7 new flags to ldap subcommands corresponding to UI options

Closes CLI part of #20716

--enable-groups false won't work due to how go parses flags - https://pkg.go.dev/flag#hdr-Command_line_flag_syntax

@TheFox0x7
add flags for managing ldap groups

Verified

This commit was signed with the committer’s verified signature.
TheFox0x7
GPG key ID: 6CA33903484AF7C2
Verified
Learn about vigilant mode
6a2d6d6
@TheFox0x7
add removal flag

Verified

This commit was signed with the committer’s verified signature.
TheFox0x7
GPG key ID: 6CA33903484AF7C2
Verified
Learn about vigilant mode
2c5d990
@TheFox0x7
fix tests and typo

Verified

This commit was signed with the committer’s verified signature.
TheFox0x7
GPG key ID: 6CA33903484AF7C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
51c45c0
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Mar 18, 2025
@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 18, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2025
TheFox0x7 and others added 2 commits March 19, 2025 09:09
@TheFox0x7
fix flag usage

Verified

This commit was signed with the committer’s verified signature.
TheFox0x7
GPG key ID: 6CA33903484AF7C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
53bd12b
@wxiaoguang
Merge branch 'main' into ldap-group-flags

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1733754
wxiaoguang
wxiaoguang reviewed Mar 19, 2025
View reviewed changes
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 19, 2025
GiteaBot and others added 3 commits March 20, 2025 00:31
@GiteaBot
Merge branch 'main' into ldap-group-flags

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c9bba3d
@TheFox0x7
improve consistency

Verified

This commit was signed with the committer’s verified signature.
TheFox0x7
GPG key ID: 6CA33903484AF7C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
ed251bf
@TheFox0x7
fix missed rename

Verified

This commit was signed with the committer’s verified signature.
TheFox0x7
GPG key ID: 6CA33903484AF7C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
cc72d7a
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2025
@GiteaBot
Merge branch 'main' into ldap-group-flags

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ad77cee
@lunny lunny merged commit 5407382 into go-gitea:main Mar 20, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 20, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2025
@TheFox0x7 TheFox0x7 deleted the ldap-group-flags branch March 20, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang

@hiifong hiifong

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheFox0x7 @wxiaoguang @hiifong @lunny @techknowlogick @GiteaBot