Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Branch struct in package modules/git #33980

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Refactor Branch struct in package modules/git #33980

wants to merge 19 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 23, 2025 •
edited
Loading

The Branch struct in modules/git package is unnecessary. We can just use a string to represent a branch

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 23, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Mar 23, 2025
@lunny lunny changed the title Remove repo field in branch struct of git module Refactor Branch struct in package modules/git Mar 23, 2025
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2025
lunny
lunny commented Mar 23, 2025
View reviewed changes
services/convert/pull.go
@@ -169,13 +169,6 @@ func ToAPIPullRequest(ctx context.Context, pr *issues_model.PullRequest, doer *u
}

if pr.Flow == issues_model.PullRequestFlowAGit {
gitRepo, err := gitrepo.OpenRepository(ctx, pr.BaseRepo)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 146 has created gitRepo.

@lunny lunny force-pushed the lunny/remove_unnecessary_repo_branch branch from d537b13 to c46d935 Compare March 23, 2025 00:51
yp05327
yp05327 reviewed Mar 25, 2025
View reviewed changes
yp05327
yp05327 reviewed Mar 25, 2025
View reviewed changes
@lunny lunny force-pushed the lunny/remove_unnecessary_repo_branch branch from c352d62 to e5f8538 Compare March 28, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunny @yp05327 @GiteaBot