fix org repo creation being limited by user limits

[TheFox0x7]

fixes an issue where user is unable to create new repository in organization via UI if repository limits are in place and user has exhausted them for their own namespace.

closes: #15504

[TheFox0x7]

Docs for behavior difference:

Previous:

1. User and Org has not exhausted their limits
   User can create repository in user namespace and in org namespace
2. Org has exhausted limits
   User can create repo, org does not show up in the list
3. User has exhausted limits but org did not
   Button is disabled and warning displayed on page load. User namespace and organization are displayed in the list
4. Both exhausted their limits
   Button is disabled, warning displayed. User namespace is visible in the list but org is not.

Proposed:

1. No changes
2. No changes
3. Button is enabled, warning shows up after user tries to create repository in their own namespace. Creating in org is not blocked
4. Button is enabled, warning shows up for user namespace, org is not listed.

---

Writing this there's an alternative solution which is to remove user namespace from the list too (like orgs aren't added), but I think is this simpler and less confusing.

[wxiaoguang]

Can we add some comments? IIRC this is a longstanding problem, many discussions, still unresolved .... (ps: fix ui bug when user can't create repo but org can #15924 )

---

ps: it looks good to me to leave the check to backend, but do not block user by the frontend.

[TheFox0x7]

I'd like to give users an early warning that the action will fail but I think it's a more complicated solution which would end up needing JS or more understanding of frontend which I lack ATM. Maybe the page should be redone from scratch - no clue there.

Where should I add the comments (and anything in particular you'd want me to put in them)?

posting techknowlogick's comment so it's not lost in discord:

for your org limit PR I had a few Qs. I just wanted to make sure that even tho buttons may be enabled/disabled that if a user still attempted to create one and the namespace faced exhaustion, that it'd still be blocked. And I'm wondering about a possible PR that would be related, is blocking repo transfers if the accepting namespace is exhausted.

I've tested it manually and user gets the same error as before, just after submitting the form now.
Transfers aren't affected by limits at all from what I've tested

[wxiaoguang]

I think it's a more complicated solution which would end up needing JS

I will take a try

[wxiaoguang]

Not sure whether it could apply to 1.23 clearly. If there is conflict, I could backport it manually.

[wxiaoguang]

Wait for more feedbacks before merge.

[TheFox0x7]

Case where user has no space left and there's no orgs with space either looks off to me:

The field is clickable but nothing happens on click. I don't think it's intended behavior

[wxiaoguang]

Finally, JS wins, and it is less tricky than the tmpl patches.

[wxiaoguang]

Case where user has no space left and there's no orgs with space either looks off to me:
The field is clickable but nothing happens on click. I don't think it's intended behavior

Does the new change look good to you?

[TheFox0x7]

Almost as it's now possible to submit the form and get two errors.

I guess since JS handles this now button could be disabled dynamically?

[wxiaoguang]

I would like to keep them as-is, because these messages belong to different logic.

Or, maybe we could just disable the "submit" button, to avoid the duplicate error message?

[TheFox0x7]

That's what I was suggesting - to disable submit button when user namespace is chosen (if appropriate)

[wxiaoguang]

Done in the new commit:

[TheFox0x7]

LGTM