Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix check-attr bug (#34029) #34033

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Try to fix check-attr bug (#34029) #34033

merged 1 commit into from
Mar 27, 2025

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Mar 27, 2025 •
edited by wxiaoguang
Loading

Backport #34029 by wxiaoguang

@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Mar 27, 2025
@GiteaBot GiteaBot requested a review from lunny March 27, 2025 05:07
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 27, 2025
@GiteaBot GiteaBot added this to the 1.23.7 milestone Mar 27, 2025
@GiteaBot GiteaBot requested a review from yp05327 March 27, 2025 05:07
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 27, 2025 05:07
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 27, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2025
@wxiaoguang wxiaoguang merged commit 690e810 into go-gitea:release/v1.23 Mar 27, 2025
26 checks passed
@wxiaoguang wxiaoguang mentioned this pull request Apr 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@yp05327 yp05327 Awaiting requested review from yp05327

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.7
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @lunny @wxiaoguang