Improve notifications to fix commit notification and support release notification #34803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
kerwin612
approved these changes
Jul 2, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jul 2, 2025
wxiaoguang
reviewed
Jul 3, 2025
| if ctx.IsSigned && !release.IsTag { | ||
| err = activities_model.SetReleaseReadBy(ctx, release.ID, ctx.Doer.ID) | ||
| if err != nil { | ||
| ctx.ServerError("SetReleaseReadBy", err) |
There was a problem hiding this comment.
TBH I really had enough for such copy-paste if ... err != nil { ctx.ServerError(...) }. It's difficult to read, the message mismatches, and the "return" is easy to forget.
Not really related to this PR, but why not introduce a better approach (I have proposed)
There was a problem hiding this comment.
Could you point me to the link for the proposed approach?
There was a problem hiding this comment.
I just reiterated it again recently:
wxiaoguang
reviewed
Jul 3, 2025
|
|
||
| updatedByIndex := schemas.NewIndex("idx_notification_updated_by", schemas.IndexType) | ||
| updatedByIndex.AddColumn("updated_by") | ||
| indices = append(indices, updatedByIndex) |
There was a problem hiding this comment.
Are these indices well-designed and correct?
You can't just add index to every column and expect that "oh it should work".
Does database work really work that way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improved notifications.