-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fixed minor typos in two files #HSFDPMUW #34944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: MrMars98 <[email protected]>
I use the hashtag for a project at my university Signed-off-by: MrMars98 <[email protected]>
Thanks for the PR, are you able to provide more context of the hashtag/your university course? |
I've looked into this out of curiosity. I have not found which university runs this course but it has been running since 2022. Btw consider letting whoever runs the course know that the arbitrary tag with 0 context is a very weird choice. Especially for a title which is sometimes automated into release notes. PR body would be a better place IMO for it but I know it's most likely not up to you. |
I can confirm. I'm at the same university and funnily enough also visited that course (my PRs). For every PR with that hashtag (max. 5) you'll get points which you need to reach the best possible grade.
The only requirement is to have a merged PR with the hashtag in the title. The lecture is mostly visited by first semester students (some of whom have just learned programming), so typofixing is the best and fasted thing they can do imo.
Already did, I also think it's a bad choice but the lecturer didn't want to change it (but you can still say it @MrMars98, maybe he'll change his mind if more students mention it). He uses some script to crawl all PRs the students send to him to check if the title contains the hashtag (at least it was like that when I visited it). |
Yeah, the whole course pretty much told him that it's stupid and he said he will consider changing it for the next time he does it (he probably won't). The hashtag is unfortunately required in the title. |
* giteaofficial/main: [skip ci] Updated translations via Crowdin Rerun job only when run is done (go-gitea#34970) Enable gocritic `equalFold` and fix issues (go-gitea#34952) Fixed minor typos in two files #HSFDPMUW (go-gitea#34944) Improve project & label color picker and image scroll (go-gitea#34971) Refactor webhook and fix feishu/lark secret (go-gitea#34961) Improve OAuth2 provider (correct Issuer, respect ENABLED) (go-gitea#34966) Merge index.js (go-gitea#34963) [skip ci] Updated translations via Crowdin Mark old reviews as stale on agit pr updates (go-gitea#34933) Refactor "delete-button" to "link-action" (go-gitea#34962) Refactor frontend unique id & comment (go-gitea#34958) Refactor some trivial problems (go-gitea#34959) Upgrade security public key (go-gitea#34956) Fix git graph page (go-gitea#34948) Update JS dependencies (go-gitea#34951) Refactor head navbar icons (go-gitea#34922) # Conflicts: # templates/base/head_navbar.tmpl
Fixed minor typos in CODE_OF_CONDUCT.md and README.md
I use the hashtag for a project at my university