Add missing dependency of database tests on backend #36073
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
fixes this error:
make test-sqlite
go test -c code.gitea.io/gitea/tests/integration -o integrations.sqlite.test -tags ' sqlite sqlite_unlock_notify'
sed -e 's|{{REPO_TEST_DIR}}||g' \
-e 's|{{TEST_LOGGER}}|test,file|g' \
-e 's|{{TEST_TYPE}}|integration|g' \
tests/sqlite.ini.tmpl > tests/sqlite.ini
GITEA_ROOT="/home/hramrach/gitea" GITEA_CONF=tests/sqlite.ini ./integrations.sqlite.test
Could not find gitea binary at /home/hramrach/gitea/gitea
make: *** [Makefile:506: test-sqlite] Error 1
silverwind
approved these changes
Dec 2, 2025
GiteaBot
added
lgtm/need 1
Member
|
CI failures are unrelated and will be fixed with #36074. |
Member
Actually no, not entirely unrelated. |
delvh
previously approved these changes
Dec 3, 2025
GiteaBot
added
lgtm/done
Contributor
|
Well, I don't think this "fix" is right and can be approved as the current implementation. @silverwind @delvh , see the CI failures. There are more details. |
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing make file dependency:
git clone https://github.com/go-gitea/gitea.git
make -C gitea test-sqlite
go test -c code.gitea.io/gitea/tests/integration -o integrations.sqlite.test -tags ' sqlite sqlite_unlock_notify'
sed -e 's|{{REPO_TEST_DIR}}||g'
-e 's|{{TEST_LOGGER}}|test,file|g'
-e 's|{{TEST_TYPE}}|integration|g'
tests/sqlite.ini.tmpl > tests/sqlite.ini
GITEA_ROOT="/home/hramrach/gitea" GITEA_CONF=tests/sqlite.ini ./integrations.sqlite.test
Could not find gitea binary at /home/hramrach/gitea/gitea
make: *** [Makefile:506: test-sqlite] Error 1