-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent interface type array from causing runtime errors #7361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thankyou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests?
Can I just write test code? |
You can add unit tests to show what this PR fixes. https://github.com/go-gorm/gorm/blob/master/tests/create_test.go |
I guess I was wrong. If I change it one by one like this, the sideEffect seems to be too big. I thought of another way, so I'll upload the pr again. |
What did this pull request do?
fix: prevent interface type array from causing runtime errors
It has been modified to find out the value when it is an interface array.
User Case Description
In this case, create is allowed.