refactor(fsnotifyext): remove unnecessary mutex usage from Deduper #2196
+9
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a small refactor of the
Deduper
component, here's a list of the introduced changes :Deduper
timers map to goroutine, to avoid mutex usage as it's read from / written to from a single goroutine.Deduper.GetChan
now returns a receive only channel, as only the internalfsnotify.Watcher
instance should be allowed to send events to it.fsnotify.Event.Has
to check against Chmod operations (as per recommended by thefsnotify.Event.Op
godoc).Executor.watchTasks
- remove check against Chmod operations, it's already handled in theDeduper.GetChan
goroutine.Deduper.GetChan
method to explain that.go mod tidy
.Following the contributing guidelines, I will squash the commits upon merging (if it ever happens ^^).
Thank you :)