Skip to content

fix: fuzzy model was not instanciated #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fuzzy model was not instanciated #2200

wants to merge 3 commits into from

Conversation

vmaerten
Copy link
Member

@vmaerten vmaerten commented Apr 23, 2025

Linked to #2192

Tested locally :
image

@vmaerten vmaerten marked this pull request as ready for review April 23, 2025 07:33
@vmaerten vmaerten requested review from andreynering and pd93 April 23, 2025 07:33
@vmaerten vmaerten linked an issue Apr 23, 2025 that may be closed by this pull request
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, love a one character fix. Maybe a quick test to ensure this doesn't regress again? I'm amazed it took 2.5 years for someone to notice 😆

@vmaerten
Copy link
Member Author

You are totaly right!
I've added it to executor_test

I just wanted to say, the way you refactored all tests is amazing. Way simpler to use, thanks a lot for this

@vmaerten vmaerten requested a review from pd93 April 23, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzzy suggestions for tasks no longer work
2 participants