Use standard In_channel.with_open_* and Out_channel.with_open_* where possible
#1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… possible (issue #1477)
…arshal (issue #1477) This should also be more efficient because BatMarshal.output and BatMarshal.input convert everything via string.
sim642
added
performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #1477.
I found out that I didn't need to roll all the
Fun.protectstuff in #1875 myself. It exists in the OCamlStdlibsince 4.14.I then also looked through other file opens and ported them to this safer pattern. Some places were even missing
close.Moreover, this should also be more efficient because
BatMarshal.outputandBatMarshal.inputconvert everything viastring.TODO
Marshalusages.