-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update country/state info #1798
base: dev
Are you sure you want to change the base?
Conversation
'LI' => __( 'O\'Higgins', 'lifterlms' ), | ||
'RM' => __( 'Santiago Metropolitan Region', 'lifterlms' ), | ||
'TA' => __( 'Tarapacá Region', 'lifterlms' ), | ||
'AI' => __( 'Aisén del General Carlos Ibañez del Campo', 'lifterlms' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot find any occurrence of "Aisén", "Aysén" seems the correct one.
What's the source of all these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the source of the updates to Chile: dr5hn/countries-states-cities-database#255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On wikipedia I see that "Aysén" is the official spelling and it is sometimes spelled with an i instead of a y:
The first line has this: https://en.wikipedia.org/wiki/Ays%C3%A9n_Region
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think nobody wiill complain...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I think I'm fine with this, but the truth is that I have no idea :D
I'm wondering how we can better manage this... My idea of pulling from an external database was an attempt to relieve us from having to maintain and keep this updated and be the "source" of information. However, it's hard to do because we can't verify and we have to trust the external source. I'm wondering if we could somehow enlist our international users to help us maintain this through a combination of using the external source and then having updates approved/improved by a representative of that country. For example, @eri-trabiccolo we changed Italian data from the source based on your feedback as an Italian. We have a pending update from a user in Singapore, we were alerted to a potential issue with Germany's states... There's a lot of ground to cover, of course, and we could elect to just do it manually but that's a lot of work to maintain. |
Yeah I think that we discussed this and that was the plan, start from an external source and then wait for feedback. |
When we get feedback from users, we should either submit an issue upstream to https://github.com/dr5hn/countries-states-cities-database, or ask our user to. |
It's a little bit hard justify to a customer that, despite we trust them, we're not going to make the change they suggested until a 3rd party lib validates it... |
Description
Locale updates from external databases
How has this been tested?
Screenshots
Types of changes
Data updates
Checklist: